From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
Cc: "Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
netdev@vger.kernel.org,
"Jakub Kicinski" <jakub.kicinski@netronome.com>,
"John Fastabend" <john.fastabend@gmail.com>,
brouer@redhat.com, "Tariq Toukan" <tariqt@mellanox.com>,
"Björn Töpel" <bjorn.topel@intel.com>
Subject: Re: [PATCH v8 bpf-next 00/10] veth: Driver XDP
Date: Fri, 3 Aug 2018 11:45:38 +0200 [thread overview]
Message-ID: <20180803114538.382664c8@redhat.com> (raw)
In-Reply-To: <1533283098-2397-1-git-send-email-makita.toshiaki@lab.ntt.co.jp>
On Fri, 3 Aug 2018 16:58:08 +0900
Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp> wrote:
> This patch set introduces driver XDP for veth.
> Basically this is used in conjunction with redirect action of another XDP
> program.
>
> NIC -----------> veth===veth
> (XDP) (redirect) (XDP)
>
I'm was playing with V7 on my testlab yesterday and I noticed one
fundamental issue. You are not updating the "ifconfig" stats counters,
when in XDP mode. This makes receive or send via XDP invisible to
sysadm/management tools. This for-sure is going to cause confusion...
I took a closer look at other driver. The ixgbe driver is doing the
right thing. Driver i40e have a bug, where RX/TX stats are swapped
getting (strange!). The mlx5 driver is not updating the regular RX/TX
counters, but A LOT of other ethtool stats counters (which are the ones
I usually monitor when testing).
So, given other drivers also didn't get this right, we need to have a
discussion outside your/this patchset. Thus, I don't want to
stop/stall this patchset, but this is something we need to fixup in a
followup patchset to other drivers as well.
Thus, I'm acking the patchset, but I request that we do a joint effort
of fixing this as followup patches.
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2018-08-03 11:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-03 7:58 [PATCH v8 bpf-next 00/10] veth: Driver XDP Toshiaki Makita
2018-08-03 7:58 ` [PATCH v8 bpf-next 01/10] net: Export skb_headers_offset_update Toshiaki Makita
2018-08-03 7:58 ` [PATCH v8 bpf-next 02/10] veth: Add driver XDP Toshiaki Makita
2018-08-07 14:26 ` Daniel Borkmann
2018-08-08 0:53 ` Toshiaki Makita
2018-08-03 7:58 ` [PATCH v8 bpf-next 03/10] veth: Avoid drops by oversized packets when XDP is enabled Toshiaki Makita
2018-08-03 7:58 ` [PATCH v8 bpf-next 04/10] xdp: Helper function to clear kernel pointers in xdp_frame Toshiaki Makita
2018-08-03 9:06 ` Jesper Dangaard Brouer
2018-08-03 7:58 ` [PATCH v8 bpf-next 05/10] veth: Handle xdp_frames in xdp napi ring Toshiaki Makita
2018-08-03 9:07 ` Jesper Dangaard Brouer
2018-08-03 7:58 ` [PATCH v8 bpf-next 06/10] veth: Add ndo_xdp_xmit Toshiaki Makita
2018-08-03 7:58 ` [PATCH v8 bpf-next 07/10] bpf: Make redirect_info accessible from modules Toshiaki Makita
2018-08-03 7:58 ` [PATCH v8 bpf-next 08/10] xdp: Helpers for disabling napi_direct of xdp_return_frame Toshiaki Makita
2018-08-03 7:58 ` [PATCH v8 bpf-next 09/10] veth: Add XDP TX and REDIRECT Toshiaki Makita
2018-08-03 7:58 ` [PATCH v8 bpf-next 10/10] veth: Support per queue XDP ring Toshiaki Makita
2018-08-03 9:45 ` Jesper Dangaard Brouer [this message]
2018-08-03 11:14 ` [PATCH v8 bpf-next 00/10] veth: Driver XDP Toshiaki Makita
2018-08-06 8:22 ` Björn Töpel
2018-08-10 14:24 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180803114538.382664c8@redhat.com \
--to=brouer@redhat.com \
--cc=ast@kernel.org \
--cc=bjorn.topel@intel.com \
--cc=daniel@iogearbox.net \
--cc=jakub.kicinski@netronome.com \
--cc=john.fastabend@gmail.com \
--cc=makita.toshiaki@lab.ntt.co.jp \
--cc=netdev@vger.kernel.org \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).