From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] ethtool: Remove trailing semicolon for static inline Date: Sat, 04 Aug 2018 14:56:49 -0700 (PDT) Message-ID: <20180804.145649.96983648171806038.davem@davemloft.net> References: <20180804212040.27562-1-f.fainelli@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: f.fainelli@gmail.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:57674 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728882AbeHDX7A (ORCPT ); Sat, 4 Aug 2018 19:59:00 -0400 In-Reply-To: <20180804212040.27562-1-f.fainelli@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Florian Fainelli Date: Sat, 4 Aug 2018 14:20:40 -0700 > Android's header sanitization tool chokes on static inline functions having a > trailing semicolon, leading to an incorrectly parsed header file. While the > tool should obviously be fixed, also fix the header files for the two affected > functions: ethtool_get_flow_spec_ring() and ethtool_get_flow_spec_ring_vf(). > > Fixes: 8cf6f497de40 ("ethtool: Add helper routines to pass vf to rx_flow_spec") > Reporetd-by: Blair Prescott > Signed-off-by: Florian Fainelli Applied, thanks Florian. Trailing semicolon removal has become so trendy all of a sudden...