From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Pfaff Subject: Re: [PATCH RFC net-next] openvswitch: Queue upcalls to userspace in per-port round-robin order Date: Fri, 3 Aug 2018 17:54:52 -0700 Message-ID: <20180804005452.GI29662@ovn.org> References: <20180704142342.21740-1-mcroce@redhat.com> <20180731220657.GC29662@ovn.org> <20180803185241.4ac0d1e5@epycfail> <20180803230108.GU29662@ovn.org> <20180804024324.4d900b5e@epycfail> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org, jpettit-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org, netdev , Jiri Benc To: Stefano Brivio Return-path: Content-Disposition: inline In-Reply-To: <20180804024324.4d900b5e@epycfail> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ovs-dev-bounces-yBygre7rU0TnMu66kgdUjQ@public.gmane.org Errors-To: ovs-dev-bounces-yBygre7rU0TnMu66kgdUjQ@public.gmane.org List-Id: netdev.vger.kernel.org On Sat, Aug 04, 2018 at 02:43:24AM +0200, Stefano Brivio wrote: > On Fri, 3 Aug 2018 16:01:08 -0700 > Ben Pfaff wrote: > > I would be very pleased if we could integrate a simple mechanism for > > fairness, based for now on some simple criteria like the source port, > > but thinking ahead to how we could later make it gracefully extensible > > to consider more general and possibly customizable criteria. > > We could change the patch so that instead of just using the vport for > round-robin queue insertion, we generalise that and use "buckets" > instead of vports, and have a set of possible functions that are called > instead of using port_no directly in ovs_dp_upcall_queue_roundrobin(), > making this configurable via netlink, per datapath. > > We could implement selection based on source port or a hash on the > source 5-tuple, and the relevant bits of > ovs_dp_upcall_queue_roundrobin() would look like this: [...] > What do you think? I'd support that. Thanks.