From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] net/bridge/br_multicast: remove redundant variable "err" Date: Sun, 05 Aug 2018 17:33:36 -0700 (PDT) Message-ID: <20180805.173336.2098484669514510834.davem@davemloft.net> References: <1533478723-18361-1-git-send-email-zhongjiang@huawei.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: stephen@networkplumber.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: zhongjiang@huawei.com Return-path: In-Reply-To: <1533478723-18361-1-git-send-email-zhongjiang@huawei.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: zhong jiang Date: Sun, 5 Aug 2018 22:18:43 +0800 > @@ -1797,7 +1795,7 @@ static int br_multicast_ipv4_rcv(struct net_bridge *br, > struct sk_buff *skb_trimmed = NULL; > const unsigned char *src; > struct igmphdr *ih; > - int err; > + int err = 0; > > err = ip_mc_check_igmp(skb, &skb_trimmed); The initialization of err to '0' is unnecessary, it gets assigned on the very next line.