From: Al Viro <viro@ZenIV.linux.org.uk>
To: Santosh Raspatur <santosh@chelsio.com>
Cc: netdev@vger.kernel.org
Subject: [RFC] weirdness in cxgb3_main.c:init_tp_parity()
Date: Sun, 5 Aug 2018 18:46:49 +0100 [thread overview]
Message-ID: <20180805174649.GI15082@ZenIV.linux.org.uk> (raw)
for (i = 0; i < 2048; i++) {
...
req->l2t_idx = htonl(V_L2T_W_IDX(i));
...
in there is very odd; l2t_idx is a 16bit field, and
#define V_L2T_W_IDX(x) ((x) << S_L2T_W_IDX)
#define S_L2T_W_IDX 0
IOW, we are taking htonl(something in range 0..2047) and
shove it into 16bit field. Which would, on a little-endian
host, be a fancy way of spelling
req->l2t_idx = 0;
What's the intended behaviour there? I'm not familiar with
the hardware in question; this smells like a typoed
req->l2t_idx = htons(...)
but how does the current code manage to work (i.e. does
anything even care about the value stored there)? It's not
a big-endian-only driver, after all...
reply other threads:[~2018-08-05 19:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180805174649.GI15082@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=santosh@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).