From mboxrd@z Thu Jan 1 00:00:00 1970 From: Willem de Bruijn Subject: [PATCH net-next] net: report netlink extack only if set Date: Sun, 5 Aug 2018 15:48:01 -0400 Message-ID: <20180805194801.173032-1-willemdebruijn.kernel@gmail.com> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: davem@davemloft.net, stephen@networkplumber.org, Willem de Bruijn To: netdev@vger.kernel.org Return-path: Received: from mail-qk0-f193.google.com ([209.85.220.193]:45062 "EHLO mail-qk0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726647AbeHEVx7 (ORCPT ); Sun, 5 Aug 2018 17:53:59 -0400 Received: by mail-qk0-f193.google.com with SMTP id c192-v6so7493427qkg.12 for ; Sun, 05 Aug 2018 12:48:19 -0700 (PDT) Sender: netdev-owner@vger.kernel.org List-ID: From: Willem de Bruijn Initialize extack in dev_set_mtu and report only if set. Fixes: 7a4c53bee332 ("net: report invalid mtu value via netlink extack") Reported-by: syzbot Signed-off-by: Willem de Bruijn --- net/core/dev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/core/dev.c b/net/core/dev.c index 36e994519488e..1d0122a766019 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -7580,11 +7580,11 @@ int dev_set_mtu_ext(struct net_device *dev, int new_mtu, int dev_set_mtu(struct net_device *dev, int new_mtu) { - struct netlink_ext_ack extack; + struct netlink_ext_ack extack = {}; int err; err = dev_set_mtu_ext(dev, new_mtu, &extack); - if (err) + if (err && extack._msg) net_err_ratelimited("%s: %s\n", dev->name, extack._msg); return err; } -- 2.18.0.597.ga71716f1ad-goog