From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Westphal Subject: Re: Linux kernel error stack Date: Sun, 5 Aug 2018 23:01:21 +0200 Message-ID: <20180805210121.holfmbbkqywpp3zd@breakpoint.cc> References: <20180805094835.3e2njq2f3plj7njj@breakpoint.cc> <20180805194212.r2vdjqjr44gxqgo5@breakpoint.cc> <20180805200254.56dm374j7bsprwrj@breakpoint.cc> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Florian Westphal , netdev@vger.kernel.org To: Satish Patel Return-path: Received: from Chamillionaire.breakpoint.cc ([146.0.238.67]:35718 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726794AbeHEXHQ (ORCPT ); Sun, 5 Aug 2018 19:07:16 -0400 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: Satish Patel wrote: > After reading further related DHCP checksum issue, it seems we need > that rules when you running DHCP on same host machine where your guest > using host DHCP service, in that case virtual nic won't do checksum. > If your DHCP running on different host then your physical nic perform > checksum. Partially right, its only needed for older dhcp software that relies on packet-header checksum correctness (metadata contains info when checksum will be filled in by nic later, modern servers will use that and ignore the packet-header checksums in this case). If you remove the rule and your VMs still get leases via DHCP then the CHECKSUM workaround isn't needed.