Netdev List
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Michal Kubecek <mkubecek@suse.cz>
Cc: Florian Westphal <fw@strlen.de>,
	Satish Patel <satish.txt@gmail.com>,
	netdev@vger.kernel.org
Subject: Re: Linux kernel error stack
Date: Mon, 6 Aug 2018 01:15:37 +0200	[thread overview]
Message-ID: <20180805231537.vyotuhqbcecxuqzh@breakpoint.cc> (raw)
In-Reply-To: <20180805230631.rc6wrdlyo6ewmfjx@unicorn.suse.cz>

Michal Kubecek <mkubecek@suse.cz> wrote:
> Oops, exactly this issue was already discussed almost a year ago:
> 
>   http://lkml.kernel.org/r/20170824104824.2C318A0F3A@unicorn.suse.cz
> 
> But something more urgent came and I forgot to get back to it. :-(

I did not even remeber, thanks for the pointer.
So I think best course of action is to update man page to clearly
say this only works in postrouting and with udp, and is ONLY
intended for working around old dhcp software.

>From kernel, have checkentry emit a warning
when this is used for protocols other than udp,
and make this a no-op for everything else.

Same for postrouting: warn from checkentry if the hook is something
else, and have target function not do anything for !postrouting.

Does that make sense?

I can work on a patch later this week if needed.

  reply	other threads:[~2018-08-06  1:21 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-05  1:24 Linux kernel error stack Satish Patel
2018-08-05  9:48 ` Florian Westphal
2018-08-05 12:43   ` Satish Patel
2018-08-05 19:42     ` Florian Westphal
2018-08-05 19:54       ` Satish Patel
2018-08-05 19:56         ` Satish Patel
2018-08-05 20:01           ` Satish Patel
2018-08-05 20:02           ` Florian Westphal
2018-08-05 20:09             ` Satish Patel
2018-08-05 20:15               ` Satish Patel
2018-08-05 20:39                 ` Satish Patel
2018-08-05 20:53                   ` Satish Patel
2018-08-05 21:01                     ` Florian Westphal
2018-08-05 21:03                 ` Florian Westphal
2018-08-05 23:06                   ` Michal Kubecek
2018-08-05 23:15                     ` Florian Westphal [this message]
2018-08-06  0:06                       ` Michal Kubecek
2018-08-06  0:19                         ` Florian Westphal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180805231537.vyotuhqbcecxuqzh@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=mkubecek@suse.cz \
    --cc=netdev@vger.kernel.org \
    --cc=satish.txt@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox