From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Westphal Subject: Re: Linux kernel error stack Date: Mon, 6 Aug 2018 02:19:12 +0200 Message-ID: <20180806001912.474wc334aymu4bmd@breakpoint.cc> References: <20180805194212.r2vdjqjr44gxqgo5@breakpoint.cc> <20180805200254.56dm374j7bsprwrj@breakpoint.cc> <20180805210342.qmzxtubtjp53n4iq@breakpoint.cc> <20180805230631.rc6wrdlyo6ewmfjx@unicorn.suse.cz> <20180805231537.vyotuhqbcecxuqzh@breakpoint.cc> <20180806000645.b3z4b7lxjhr2qaiy@unicorn.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Florian Westphal , Satish Patel , netdev@vger.kernel.org To: Michal Kubecek Return-path: Received: from Chamillionaire.breakpoint.cc ([146.0.238.67]:36276 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726903AbeHFCZk (ORCPT ); Sun, 5 Aug 2018 22:25:40 -0400 Content-Disposition: inline In-Reply-To: <20180806000645.b3z4b7lxjhr2qaiy@unicorn.suse.cz> Sender: netdev-owner@vger.kernel.org List-ID: Michal Kubecek wrote: > On Mon, Aug 06, 2018 at 01:15:37AM +0200, Florian Westphal wrote: > > Michal Kubecek wrote: > > > Oops, exactly this issue was already discussed almost a year ago: > > > > > > http://lkml.kernel.org/r/20170824104824.2C318A0F3A@unicorn.suse.cz > > > > > > But something more urgent came and I forgot to get back to it. :-( > > > > I did not even remeber, thanks for the pointer. > > So I think best course of action is to update man page to clearly > > say this only works in postrouting and with udp, and is ONLY > > intended for working around old dhcp software. > > As GSO for UDP is on its way to mainline, one might get into trouble > even with UDP if the rule is not specific enough. Yes, we still need a fix to ignore GSO too.