From: David Miller <davem@davemloft.net>
To: viro@ZenIV.linux.org.uk
Cc: kumaras@chelsio.com, rahul.lakkireddy@chelsio.com,
netdev@vger.kernel.org
Subject: Re: [endianness bug] cxgb4: mk_act_open_req() buggers ->{local,peer}_ip on big-endian hosts
Date: Tue, 07 Aug 2018 12:35:38 -0700 (PDT) [thread overview]
Message-ID: <20180807.123538.1789071603383048283.davem@davemloft.net> (raw)
In-Reply-To: <20180805172238.GH15082@ZenIV.linux.org.uk>
From: Al Viro <viro@ZenIV.linux.org.uk>
Date: Sun, 5 Aug 2018 18:22:38 +0100
> Unlike fs.val.lport and fs.val.fport, cxgb4_process_flow_match()
> sets fs.val.{l,f}ip to net-endian values without conversion - they come
> straight from flow_dissector_key_ipv4_addrs ->dst and ->src resp. So
> the assignment in mk_act_open_req() ought to be a straigh copy.
>
> As far as I know, T4 PCIe cards do exist, so it's not as if that
> thing could only be found on little-endian systems...
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Applied.
prev parent reply other threads:[~2018-08-07 21:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-05 17:22 [endianness bug] cxgb4: mk_act_open_req() buggers ->{local,peer}_ip on big-endian hosts Al Viro
2018-08-06 12:15 ` Rahul Lakkireddy
2018-08-14 21:25 ` Al Viro
2018-08-17 13:05 ` Ganesh Goudar
2018-08-17 15:43 ` Al Viro
2018-08-17 16:34 ` David Miller
2018-08-17 18:09 ` Al Viro
2018-08-17 18:58 ` Al Viro
2018-08-17 18:59 ` Al Viro
2018-08-17 19:44 ` Al Viro
2018-08-22 10:29 ` Ganesh Goudar
2018-08-07 19:35 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180807.123538.1789071603383048283.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kumaras@chelsio.com \
--cc=netdev@vger.kernel.org \
--cc=rahul.lakkireddy@chelsio.com \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).