From: David Miller <davem@davemloft.net>
To: claudiu.beznea@microchip.com
Cc: nicolas.ferre@microchip.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, harinik@xilinx.com,
jennifer.dahm@ni.com, nathan.sullivan@ni.com, rafalo@cadence.com,
harinikatakamlinux@gmail.com
Subject: Re: [PATCH 0/3] net: macb: add pad and fcs support
Date: Tue, 07 Aug 2018 13:19:09 -0700 (PDT) [thread overview]
Message-ID: <20180807.131909.2224882167750246331.davem@davemloft.net> (raw)
In-Reply-To: <1533633914-30264-1-git-send-email-claudiu.beznea@microchip.com>
From: Claudiu Beznea <claudiu.beznea@microchip.com>
Date: Tue, 7 Aug 2018 12:25:11 +0300
> In [1] it was reported that UDP checksum is offloaded to hardware no mather
> it was previously computed in software or not. The proposal on [1] was to
> disable TX checksum offload.
>
> This series (mostly patch 3/3) address the issue described at [1] by
> setting NOCRC bit to TX buffer descriptor for SKBs that arrived from
> networking stack with checksum computed. For these packets padding and FCS
> need to be added (hardware doesn't compute them if NOCRC bit is set). The
> minimum packet size that hardware expects is 64 bytes (including FCS).
> This feature could not be used in case of GSO, so, it was used only for
> no GSO SKBs.
>
> For SKBs wich requires padding and FCS computation macb_pad_and_fcs()
> checks if there is enough headroom and tailroom in SKB to avoid copying
> SKB structure. Since macb_pad_and_fcs() may change SKB the
> macb_pad_and_fcs() was places in macb_start_xmit() b/w macb_csum_clear()
> and skb_headlen() calls.
>
> This patch was tested with pktgen in kernel tool in a script like this:
> (pktgen_sample01_simple.sh is at [2]):
...
Series applied to net-next, thanks.
prev parent reply other threads:[~2018-08-07 20:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-07 9:25 [PATCH 0/3] net: macb: add pad and fcs support Claudiu Beznea
2018-08-07 9:25 ` [PATCH 1/3] net: macb: use netdev_tx_t return type for ndo_start_xmit functions Claudiu Beznea
2018-08-07 9:25 ` [PATCH 2/3] net: macb: move checksum clearing outside of spinlock Claudiu Beznea
2018-08-07 9:25 ` [PATCH 3/3] net: macb: add support for padding and fcs computation Claudiu Beznea
2018-08-07 20:19 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180807.131909.2224882167750246331.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=claudiu.beznea@microchip.com \
--cc=harinik@xilinx.com \
--cc=harinikatakamlinux@gmail.com \
--cc=jennifer.dahm@ni.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nathan.sullivan@ni.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=rafalo@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox