From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] net: aquantia: Fix IFF_ALLMULTI flag functionality Date: Wed, 08 Aug 2018 19:12:36 -0700 (PDT) Message-ID: <20180808.191236.1306091437806842745.davem@davemloft.net> References: <30bef74fcd937e168589cfdf9a148c2674742410.1533306383.git.dmitry.bogdanov@aquantia.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, darcari@redhat.com, dmitry.bogdanov@aquantia.com To: igor.russkikh@aquantia.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:47950 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725757AbeHIEfA (ORCPT ); Thu, 9 Aug 2018 00:35:00 -0400 In-Reply-To: <30bef74fcd937e168589cfdf9a148c2674742410.1533306383.git.dmitry.bogdanov@aquantia.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Igor Russkikh Date: Wed, 8 Aug 2018 14:06:32 +0300 > From: Dmitry Bogdanov > > It was noticed that NIC always pass all multicast traffic to the host > regardless of IFF_ALLMULTI flag on the interface. > The rule in MC Filter Table in NIC, that is configured to accept any > multicast packets, is turning on if IFF_MULTICAST flag is set on the > interface. It leads to passing all multicast traffic to the host. > This fix changes the condition to turn on that rule by checking > IFF_ALLMULTI flag as it should. > > Fixes: b21f502 ("net:ethernet:aquantia: Fix for multicast filter handling.") Please use 12 digits of significance for the SHA1_ID next time. > Signed-off-by: Dmitry Bogdanov Applied and queued up for -stable.