From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jiri Pirko <jiri@resnulli.us>
Subject: Re: [PATCH net-next 12/14] net: sched: act_mirred: remove dependency
 on rtnl lock
Date: Wed, 8 Aug 2018 10:03:08 +0200
Message-ID: <20180808080308.GA1998@nanopsycho>
References: <1533538465-23199-1-git-send-email-vladbu@mellanox.com>
 <1533538465-23199-13-git-send-email-vladbu@mellanox.com>
 <20180807163630.GD2890@nanopsycho>
 <vbfy3dh2tn0.fsf@reg-r-vrt-018-180.mtr.labs.mlnx>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: netdev@vger.kernel.org, davem@davemloft.net, jhs@mojatatu.com,
        xiyou.wangcong@gmail.com, pablo@netfilter.org,
        kadlec@blackhole.kfki.hu, fw@strlen.de, ast@kernel.org,
        daniel@iogearbox.net, edumazet@google.com, keescook@chromium.org,
        marcelo.leitner@gmail.com
To: Vlad Buslov <vladbu@mellanox.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wm0-f68.google.com ([74.125.82.68]:51155 "EHLO
        mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726979AbeHHKYk (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 8 Aug 2018 06:24:40 -0400
Received: by mail-wm0-f68.google.com with SMTP id s12-v6so1745983wmc.0
        for <netdev@vger.kernel.org>; Wed, 08 Aug 2018 01:06:07 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <vbfy3dh2tn0.fsf@reg-r-vrt-018-180.mtr.labs.mlnx>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Wed, Aug 08, 2018 at 09:40:35AM CEST, vladbu@mellanox.com wrote:
>
>On Tue 07 Aug 2018 at 16:36, Jiri Pirko <jiri@resnulli.us> wrote:
>> Mon, Aug 06, 2018 at 08:54:23AM CEST, vladbu@mellanox.com wrote:
>>
>> [...]
>>
>>>diff --git a/include/net/tc_act/tc_tunnel_key.h b/include/net/tc_act/tc_tunnel_key.h
>>>index 46b8c7f1c8d5..e6e475d788c6 100644
>>>--- a/include/net/tc_act/tc_tunnel_key.h
>>>+++ b/include/net/tc_act/tc_tunnel_key.h
>>>@@ -30,26 +30,47 @@ struct tcf_tunnel_key {
>>> 
>>> static inline bool is_tcf_tunnel_set(const struct tc_action *a)
>>> {
>>>+	bool ret = false;
>>> #ifdef CONFIG_NET_CLS_ACT
>>> 	struct tcf_tunnel_key *t = to_tunnel_key(a);
>>>-	struct tcf_tunnel_key_params *params = rtnl_dereference(t->params);
>>>+	struct tcf_tunnel_key_params *params;
>>> 
>>>+	rcu_read_lock();
>>>+	params = rcu_dereference(t->params);
>>> 	if (a->ops && a->ops->type == TCA_ACT_TUNNEL_KEY)
>>>-		return params->tcft_action == TCA_TUNNEL_KEY_ACT_SET;
>>>+		ret = params->tcft_action == TCA_TUNNEL_KEY_ACT_SET;
>>>+	rcu_read_unlock();
>>> #endif
>>>-	return false;
>>>+	return ret;
>>> }
>>> 
>>> static inline bool is_tcf_tunnel_release(const struct tc_action *a)
>>
>> Why are these tunnel things in a mirred patch?
>
>Mistake during re-slit. Will move those to tunnel_key patch.

Are you sure that the changes are safe? I just quickly looked over it
and it smells:
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c:
                if (is_tcf_tunnel_set(a)) {
                        info = tcf_tunnel_info(a);

Why the "t->params" can't be nulled in the middle?