From: Andrew Lunn <andrew@lunn.ch>
To: Igor Russkikh <igor.russkikh@aquantia.com>
Cc: "David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Yana Esina <yana.esina@aquantia.com>,
Nikita Danilov <nikita.danilov@aquantia.com>
Subject: Re: [PATCH net-next 2/5] net: aquantia: definitions for WOL patch
Date: Wed, 8 Aug 2018 14:06:59 +0200 [thread overview]
Message-ID: <20180808120659.GC18314@lunn.ch> (raw)
In-Reply-To: <a3e119c80dd7afa6a4622f80eb0d1cc73dabbe81.1533650064.git.igor.russkikh@aquantia.com>
> -struct __packed hw_aq_atl_utils_fw_rpc {
> +struct __packed hw_atl_utils_fw_rpc {
> u32 msg_id;
Hi Igor
There is no explanation given as to why you decided to rename this
structure. Please do the rename as a standalone patch, no
functionality change. That makes it easier to review the new
functionality.
Andrew
next prev parent reply other threads:[~2018-08-08 14:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-08 10:57 [PATCH net-next 0/5] net: aquantia: implement WOL and EEE support Igor Russkikh
2018-08-08 10:57 ` [PATCH net-next 1/5] net: aquantia: fix hw_atl_utils_fw_upload_dwords Igor Russkikh
2018-08-08 12:03 ` Andrew Lunn
2018-08-08 10:57 ` [PATCH net-next 2/5] net: aquantia: definitions for WOL patch Igor Russkikh
2018-08-08 12:06 ` Andrew Lunn [this message]
2018-08-08 10:57 ` [PATCH net-next 3/5] net: aquantia: implement WOL support Igor Russkikh
2018-08-08 12:16 ` Andrew Lunn
2018-08-08 10:57 ` [PATCH net-next 4/5] net: aquantia: implement EEE support Igor Russkikh
2018-08-08 12:27 ` Andrew Lunn
2018-08-08 10:57 ` [PATCH net-next 5/5] net: aquantia: bump driver version Igor Russkikh
2018-08-08 12:32 ` Andrew Lunn
2018-08-09 10:10 ` Igor Russkikh
2018-08-09 19:20 ` Jakub Kicinski
2018-08-12 7:53 ` Igor Russkikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180808120659.GC18314@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=igor.russkikh@aquantia.com \
--cc=netdev@vger.kernel.org \
--cc=nikita.danilov@aquantia.com \
--cc=yana.esina@aquantia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).