From: Andrew Lunn <andrew@lunn.ch>
To: Igor Russkikh <igor.russkikh@aquantia.com>
Cc: "David S . Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 5/5] net: aquantia: bump driver version
Date: Wed, 8 Aug 2018 14:32:16 +0200 [thread overview]
Message-ID: <20180808123216.GF18314@lunn.ch> (raw)
In-Reply-To: <5ad3aff3900698f8b27c7bb327427256ae847241.1533650064.git.igor.russkikh@aquantia.com>
On Wed, Aug 08, 2018 at 01:57:15PM +0300, Igor Russkikh wrote:
> Signed-off-by: Igor Russkikh <igor.russkikh@aquantia.com>
> ---
> drivers/net/ethernet/aquantia/atlantic/ver.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/aquantia/atlantic/ver.h b/drivers/net/ethernet/aquantia/atlantic/ver.h
> index 94efc64..b482601 100644
> --- a/drivers/net/ethernet/aquantia/atlantic/ver.h
> +++ b/drivers/net/ethernet/aquantia/atlantic/ver.h
> @@ -12,7 +12,7 @@
>
> #define NIC_MAJOR_DRIVER_VERSION 2
> #define NIC_MINOR_DRIVER_VERSION 0
> -#define NIC_BUILD_DRIVER_VERSION 3
> +#define NIC_BUILD_DRIVER_VERSION 4
> #define NIC_REVISION_DRIVER_VERSION 0
>
> #define AQ_CFG_DRV_VERSION_SUFFIX "-kern"
Hi Igor
Driver versions are pretty much useless. Say somebody backports this
driver into a vendor kernel. Vendor kernels are typically based on an
old kernel, plus thousands of patches. Is 2.0.4 on such a kernel the
same as 2.0.4 in 4.19?
You probably want to remove this, just the avoid people thinking is
means something.
Andrew
next prev parent reply other threads:[~2018-08-08 14:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-08 10:57 [PATCH net-next 0/5] net: aquantia: implement WOL and EEE support Igor Russkikh
2018-08-08 10:57 ` [PATCH net-next 1/5] net: aquantia: fix hw_atl_utils_fw_upload_dwords Igor Russkikh
2018-08-08 12:03 ` Andrew Lunn
2018-08-08 10:57 ` [PATCH net-next 2/5] net: aquantia: definitions for WOL patch Igor Russkikh
2018-08-08 12:06 ` Andrew Lunn
2018-08-08 10:57 ` [PATCH net-next 3/5] net: aquantia: implement WOL support Igor Russkikh
2018-08-08 12:16 ` Andrew Lunn
2018-08-08 10:57 ` [PATCH net-next 4/5] net: aquantia: implement EEE support Igor Russkikh
2018-08-08 12:27 ` Andrew Lunn
2018-08-08 10:57 ` [PATCH net-next 5/5] net: aquantia: bump driver version Igor Russkikh
2018-08-08 12:32 ` Andrew Lunn [this message]
2018-08-09 10:10 ` Igor Russkikh
2018-08-09 19:20 ` Jakub Kicinski
2018-08-12 7:53 ` Igor Russkikh
-- strict thread matches above, loose matches on Subject: below --
2018-05-29 12:56 [PATCH net-next 0/5] net: aquantia: various ethtool ops implementation Igor Russkikh
2018-05-29 12:57 ` [PATCH net-next 5/5] net: aquantia: bump driver version Igor Russkikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180808123216.GF18314@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=igor.russkikh@aquantia.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).