From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Borkmann Subject: [PATCH bpf 3/3] bpf, sockmap: fix cork timeout for select due to epipe Date: Wed, 8 Aug 2018 19:23:15 +0200 Message-ID: <20180808172315.4710-4-daniel@iogearbox.net> References: <20180808172315.4710-1-daniel@iogearbox.net> Cc: ast@kernel.org, john.fastabend@gmail.com, Daniel Borkmann To: netdev@vger.kernel.org Return-path: Received: from www62.your-server.de ([213.133.104.62]:42645 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727295AbeHHToD (ORCPT ); Wed, 8 Aug 2018 15:44:03 -0400 In-Reply-To: <20180808172315.4710-1-daniel@iogearbox.net> Sender: netdev-owner@vger.kernel.org List-ID: I ran into the same issue as a009f1f396d0 ("selftests/bpf: test_sockmap, timing improvements") where I had a broken pipe error on the socket due to remote end timing out on select and then shutting down it's sockets while the other side was still sending. We may need to do a bigger rework in general on the test_sockmap.c, but for now increase it to a more suitable timeout. Fixes: a18fda1a62c3 ("bpf: reduce runtime of test_sockmap tests") Signed-off-by: Daniel Borkmann Acked-by: John Fastabend --- tools/testing/selftests/bpf/test_sockmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/bpf/test_sockmap.c b/tools/testing/selftests/bpf/test_sockmap.c index 9e78df2..0c7d9e5 100644 --- a/tools/testing/selftests/bpf/test_sockmap.c +++ b/tools/testing/selftests/bpf/test_sockmap.c @@ -354,7 +354,7 @@ static int msg_loop(int fd, int iov_count, int iov_length, int cnt, while (s->bytes_recvd < total_bytes) { if (txmsg_cork) { timeout.tv_sec = 0; - timeout.tv_usec = 1000; + timeout.tv_usec = 300000; } else { timeout.tv_sec = 1; timeout.tv_usec = 0; -- 2.9.5