From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dominique Martinet Subject: Re: [PATCH] 9p: fix NULL pointer dereferences Date: Thu, 9 Aug 2018 00:41:11 +0200 Message-ID: <20180808224111.GB12890@nautica> References: <20180726081049.10527-1-tomasbortoli@gmail.com> <20180726081727.GA6699@nautica> <20180726094849.GA18334@nautica> <20180726142109.GA4235@nautica> <20180726221527.GA9426@nautica> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: Tomas Bortoli , David Miller , v9fs-developer@lists.sourceforge.net, netdev , LKML , syzkaller To: Dmitry Vyukov Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Dmitry Vyukov wrote on Wed, Aug 08, 2018: > > If you want to factor it in, v9fs_mount does not know which transport is > > used, but p9_client_create does know - although the functions/structs > > are all static so you need to check clnt->trans_mod->name with strcmp > > and I'm honestly not sure that's better than checking in each function.. > > > > But, as usual I'm happy as long as it works, so pick your poison :) > > So let's proceed with checking in each transport function? Yes, he's done it a while ago, just didn't se the in-reply-to field to keep part of the thread but the Reported-by was here: http://lkml.kernel.org/r/20180727110558.5479-1-tomasbortoli@gmail.com This is in linux-next right now as 631263a1b23c71 -- Dominique