From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next 00/13] More complete PHYLINK support for mv88e6xxx Date: Thu, 09 Aug 2018 11:08:40 -0700 (PDT) Message-ID: <20180809.110840.746305953595770040.davem@davemloft.net> References: <1533821929-20071-1-git-send-email-andrew@lunn.ch> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, rmk+kernel@arm.linux.org.uk, f.fainelli@gmail.com, nikita.yoush@cogentembedded.com, cphealy@gmail.com, marek.behun@nic.cz To: andrew@lunn.ch Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:33742 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726756AbeHIUeo (ORCPT ); Thu, 9 Aug 2018 16:34:44 -0400 In-Reply-To: <1533821929-20071-1-git-send-email-andrew@lunn.ch> Sender: netdev-owner@vger.kernel.org List-ID: From: Andrew Lunn Date: Thu, 9 Aug 2018 15:38:36 +0200 > Previous patches added sufficient PHYLINK support to the mv88e6xxx > that it did not break existing use cases, basically fixed-link phys. > > This patchset builds out the support so that SFP modules, up to > 2.5Gbps can be supported, on mv88e6390X, on ports 9 and 10. It also > provides a framework which can be extended to support SFPs on ports > 2-8 of mv88e6390X, 10Gbps PHYs, and SFP support on the 6352 family. > > Russell King did much of the initial work, implementing the validate > and mac_link_state calls. However, there is an important TODO in the > commit message: > > needs to call phylink_mac_change() when the port link comes up/goes down. > > The remaining patches implement this, by adding more support for the > SERDES interfaces, in particular, interrupt support so we get notified > when the SERDES gains/looses sync. > > This has been tested on the ZII devel C, using a Clearfog as peer > device. Looks good to me, series applied, thanks!