Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: tariqt@mellanox.com
Cc: netdev@vger.kernel.org, eranbe@mellanox.com, mariap@mellanox.com
Subject: Re: [PATCH net-next] net: ipv6_gre: Fix GRO to work on IPv6 over GRE tap
Date: Thu, 09 Aug 2018 14:08:10 -0700 (PDT)	[thread overview]
Message-ID: <20180809.140810.1435534399922642865.davem@davemloft.net> (raw)
In-Reply-To: <1533717990-25365-1-git-send-email-tariqt@mellanox.com>

From: Tariq Toukan <tariqt@mellanox.com>
Date: Wed,  8 Aug 2018 11:46:30 +0300

> IPv6 GRO over GRE tap is not working while GRO is not set
> over the native interface.
 ...
> This patch removes the override of the hard_header_len, and
> assigns the calculated value to needed_headroom.
> This way, the comparison in gro_list_prepare is really of
> the mac headers, and if the packets have the same mac headers
> the same_flow will be set to 1.
> 
> Performance testing: 45% higher bandwidth.
> Measuring bandwidth of single-stream IPv4 TCP traffic over IPv6
> GRE tap while GRO is not set on the native.
> NIC: ConnectX-4LX
> Before (GRO not working) : 7.2 Gbits/sec
> After (GRO working): 10.5 Gbits/sec
> 
> Signed-off-by: Maria Pasechnik <mariap@mellanox.com>
> Signed-off-by: Tariq Toukan <tariqt@mellanox.com>

Applied, thank you.

      reply	other threads:[~2018-08-09 23:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-08  8:46 [PATCH net-next] net: ipv6_gre: Fix GRO to work on IPv6 over GRE tap Tariq Toukan
2018-08-09 21:08 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180809.140810.1435534399922642865.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=eranbe@mellanox.com \
    --cc=mariap@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=tariqt@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox