From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH] net: dsa: rtl8366rb: Support port 4 (WAN)
Date: Thu, 09 Aug 2018 14:15:20 -0700 (PDT)
Message-ID: <20180809.141520.1650435824929049081.davem@davemloft.net>
References: <20180808123855.18729-1-linus.walleij@linaro.org>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: andrew@lunn.ch, vivien.didelot@savoirfairelinux.com,
        f.fainelli@gmail.com, netdev@vger.kernel.org,
        openwrt-devel@lists.openwrt.org, lede-dev@lists.infradead.org
To: linus.walleij@linaro.org
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([23.128.96.9]:37122 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727156AbeHIXl7 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 9 Aug 2018 19:41:59 -0400
In-Reply-To: <20180808123855.18729-1-linus.walleij@linaro.org>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Linus Walleij <linus.walleij@linaro.org>
Date: Wed,  8 Aug 2018 14:38:55 +0200

> The totally undocumented IO mode needs to be set to enumerator
> 0 to enable port 4 also known as WAN in most configurations,
> for ordinary traffic. The 3 bits in the register come up as
> 010 after reset, but need to be set to 000.
> 
> The Realtek source code contains a name for these bits, but
> no explanation of what the 8 different IO modes may be.
> 
> Set it to zero for the time being and drop a comment so
> people know what is going on if they run into trouble. This
> "mode zero" works fine with the D-Link DIR-685 with
> RTL8366RB.
> 
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Applied to net-next, thank you.