From: David Miller <davem@davemloft.net>
To: avagin@openvz.org
Cc: netdev@vger.kernel.org, avagin@gmail.com,
amritha.nambiar@intel.com, mst@redhat.com, jasowang@redhat.com
Subject: Re: [PATCH net-next v2] net: allow to call netif_reset_xps_queues() under cpus_read_lock
Date: Thu, 09 Aug 2018 14:26:24 -0700 (PDT) [thread overview]
Message-ID: <20180809.142624.1844562537465532129.davem@davemloft.net> (raw)
In-Reply-To: <20180809030735.16173-1-avagin@openvz.org>
From: Andrei Vagin <avagin@openvz.org>
Date: Wed, 8 Aug 2018 20:07:35 -0700
> From: Andrei Vagin <avagin@gmail.com>
>
> The definition of static_key_slow_inc() has cpus_read_lock in place. In the
> virtio_net driver, XPS queues are initialized after setting the queue:cpu
> affinity in virtnet_set_affinity() which is already protected within
> cpus_read_lock. Lockdep prints a warning when we are trying to acquire
> cpus_read_lock when it is already held.
>
> This patch adds an ability to call __netif_set_xps_queue under
> cpus_read_lock().
...
Applied, thank you.
next prev parent reply other threads:[~2018-08-09 23:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-09 3:07 [PATCH net-next v2] net: allow to call netif_reset_xps_queues() under cpus_read_lock Andrei Vagin
2018-08-09 9:15 ` Jason Wang
2018-08-09 21:26 ` David Miller [this message]
2018-08-09 22:13 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180809.142624.1844562537465532129.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=amritha.nambiar@intel.com \
--cc=avagin@gmail.com \
--cc=avagin@openvz.org \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).