From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next v2] net: allow to call netif_reset_xps_queues() under cpus_read_lock Date: Thu, 09 Aug 2018 14:26:24 -0700 (PDT) Message-ID: <20180809.142624.1844562537465532129.davem@davemloft.net> References: <20180809030735.16173-1-avagin@openvz.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, avagin@gmail.com, amritha.nambiar@intel.com, mst@redhat.com, jasowang@redhat.com To: avagin@openvz.org Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:37296 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727206AbeHIXxG (ORCPT ); Thu, 9 Aug 2018 19:53:06 -0400 In-Reply-To: <20180809030735.16173-1-avagin@openvz.org> Sender: netdev-owner@vger.kernel.org List-ID: From: Andrei Vagin Date: Wed, 8 Aug 2018 20:07:35 -0700 > From: Andrei Vagin > > The definition of static_key_slow_inc() has cpus_read_lock in place. In the > virtio_net driver, XPS queues are initialized after setting the queue:cpu > affinity in virtnet_set_affinity() which is already protected within > cpus_read_lock. Lockdep prints a warning when we are trying to acquire > cpus_read_lock when it is already held. > > This patch adds an ability to call __netif_set_xps_queue under > cpus_read_lock(). ... Applied, thank you.