Netdev List
 help / color / mirror / Atom feed
From: Yonghong Song <yhs@fb.com>
To: <ast@fb.com>, <daniel@iogearbox.net>, <netdev@vger.kernel.org>
Cc: <kernel-team@fb.com>
Subject: [PATCH bpf-next 0/3] bpf: add bpffs pretty print for hash/lru_hash maps
Date: Thu, 9 Aug 2018 08:55:18 -0700	[thread overview]
Message-ID: <20180809155521.1544888-1-yhs@fb.com> (raw)

Commit a26ca7c982cb ("bpf: btf: Add pretty print support to
the basic arraymap") added pretty print support to array map.
This patch adds pretty print for hash and lru_hash maps.

The following example shows the pretty-print result of a pinned hashmap.
Without this patch set, user will get an error instead.

    struct map_value {
            int count_a;
            int count_b;
    };

    cat /sys/fs/bpf/pinned_hash_map:

    87907: {87907,87908}
    57354: {37354,57355}
    76625: {76625,76626}
    ...

Patch #1 fixed a bug in bpffs map_seq_next() function so that
all elements in the hash table will be traversed.
Patch #2 implemented map_seq_show_elem() and map_check_btf()
callback functions for hash and lru hash maps.
Patch #3 enhanced tools/testing/selftests/bpf/test_btf.c to
test bpffs hash and lru hash map pretty print.

Yonghong Song (3):
  bpf: fix bpffs non-array map seq_show issue
  bpf: btf: add pretty print for hash/lru_hash maps
  tools/bpf: add bpffs pretty print btf test for hash/lru_hash maps

 kernel/bpf/hashtab.c                   | 44 +++++++++++++++++
 kernel/bpf/inode.c                     |  8 ++--
 tools/testing/selftests/bpf/test_btf.c | 87 ++++++++++++++++++++++++++++------
 3 files changed, 121 insertions(+), 18 deletions(-)

-- 
2.14.3

             reply	other threads:[~2018-08-09 18:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-09 15:55 Yonghong Song [this message]
2018-08-09 15:55 ` [PATCH bpf-next 1/3] bpf: fix bpffs non-array map seq_show issue Yonghong Song
2018-08-09 15:55 ` [PATCH bpf-next 2/3] bpf: btf: add pretty print for hash/lru_hash maps Yonghong Song
2018-08-09 15:55 ` [PATCH bpf-next 3/3] tools/bpf: add bpffs pretty print btf test " Yonghong Song
2018-08-10 23:32 ` [PATCH bpf-next 0/3] bpf: add bpffs pretty print " Daniel Borkmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180809155521.1544888-1-yhs@fb.com \
    --to=yhs@fb.com \
    --cc=ast@fb.com \
    --cc=daniel@iogearbox.net \
    --cc=kernel-team@fb.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox