From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dave Watson <davejwatson@fb.com>
Subject: Re: [PATCH net-next v2 1/1] net/tls: Combined memory allocation for
 decryption request
Date: Thu, 9 Aug 2018 09:25:32 -0700
Message-ID: <20180809162532.GB59729@davejwatson-mba.local>
References: <20180808232623.18075-1-vakul.garg@nxp.com>
 <20180808232623.18075-2-vakul.garg@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Cc: <netdev@vger.kernel.org>, <borisp@mellanox.com>,
        <aviadye@mellanox.com>, <davem@davemloft.net>
To: Vakul Garg <vakul.garg@nxp.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:55272 "EHLO
        mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1730419AbeHIStH (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 9 Aug 2018 14:49:07 -0400
Content-Disposition: inline
In-Reply-To: <20180808232623.18075-2-vakul.garg@nxp.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 08/09/18 04:56 AM, Vakul Garg wrote:
> For preparing decryption request, several memory chunks are required
> (aead_req, sgin, sgout, iv, aad). For submitting the decrypt request to
> an accelerator, it is required that the buffers which are read by the
> accelerator must be dma-able and not come from stack. The buffers for
> aad and iv can be separately kmalloced each, but it is inefficient.
> This patch does a combined allocation for preparing decryption request
> and then segments into aead_req || sgin || sgout || iv || aad.
> 
> Signed-off-by: Vakul Garg <vakul.garg@nxp.com>

Reviewed-by: Dave Watson <davejwatson@fb.com>

Thanks, looks good to me now.