From mboxrd@z Thu Jan 1 00:00:00 1970 From: "J. Bruce Fields" Subject: Re: [PATCH 1/3] net:svc_rdma_transport: remove unneeded variable 'ret' in rdma_listen_handler Date: Thu, 9 Aug 2018 16:06:44 -0400 Message-ID: <20180809200644.GN23873@fieldses.org> References: <1533640809-1221-1-git-send-email-zhongjiang@huawei.com> <1533640809-1221-2-git-send-email-zhongjiang@huawei.com> <2c343d78-e668-1b97-a4e6-228296da0d70@Netapp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: zhong jiang , davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Anna Schumaker Return-path: Content-Disposition: inline In-Reply-To: <2c343d78-e668-1b97-a4e6-228296da0d70@Netapp.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Tue, Aug 07, 2018 at 10:49:11AM -0400, Anna Schumaker wrote: > (Adding Bruce since he takes nfs / sunrpc server patches) Applied, thanks.--b. > > On 08/07/2018 07:20 AM, zhong jiang wrote: > > The ret is not modified after initalization, So just remove the variable > > and return 0. > > > > Signed-off-by: zhong jiang > > --- > > net/sunrpc/xprtrdma/svc_rdma_transport.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c b/net/sunrpc/xprtrdma/svc_rdma_transport.c > > index 547b2cd..2848caf 100644 > > --- a/net/sunrpc/xprtrdma/svc_rdma_transport.c > > +++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c > > @@ -296,7 +296,6 @@ static int rdma_listen_handler(struct rdma_cm_id *cma_id, > > struct rdma_cm_event *event) > > { > > struct sockaddr *sap = (struct sockaddr *)&cma_id->route.addr.src_addr; > > - int ret = 0; > > > > trace_svcrdma_cm_event(event, sap); > > > > @@ -315,7 +314,7 @@ static int rdma_listen_handler(struct rdma_cm_id *cma_id, > > break; > > } > > > > - return ret; > > + return 0; > > } > > > > static int rdma_cma_handler(struct rdma_cm_id *cma_id, > >