From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [PATCH 0/2] net/sched: Add hardware specific counters to TC actions Date: Thu, 9 Aug 2018 20:26:08 -0700 Message-ID: <20180809202608.6b816326@cakuba.netronome.com> References: <20180809150118.5275.63824.stgit@wsfd-netdev20.ntdv.lab.eng.bos.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, davem@davemloft.net, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, Simon Horman To: Eelco Chaudron Return-path: Received: from mail-pf1-f193.google.com ([209.85.210.193]:37607 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725744AbeHJFyJ (ORCPT ); Fri, 10 Aug 2018 01:54:09 -0400 Received: by mail-pf1-f193.google.com with SMTP id a26-v6so3837231pfo.4 for ; Thu, 09 Aug 2018 20:26:14 -0700 (PDT) In-Reply-To: <20180809150118.5275.63824.stgit@wsfd-netdev20.ntdv.lab.eng.bos.redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, 9 Aug 2018 11:01:18 -0400, Eelco Chaudron wrote: > Add hardware specific counters to TC actions which will be exported > through the netlink API. This makes troubleshooting TC flower offload > easier, as it possible to differentiate the packets being offloaded. It is not immediately clear why this is needed. The memory and updating two sets of counters won't come for free, so perhaps a stronger justification than troubleshooting is due? :S Netdev has counters for fallback vs forwarded traffic, so you'd know that traffic hits the SW datapath, plus the rules which are in_hw will most likely not match as of today for flower (assuming correctness). I'm slightly concerned about potential performance impact, would you be able to share some numbers for non-trivial number of flows (100k active?)?