From: David Miller <davem@davemloft.net>
To: michael.chan@broadcom.com
Cc: netdev@vger.kernel.org, dan.carpenter@oracle.com,
vasundhara-v.volam@broadcom.com
Subject: Re: [PATCH net-next] bnxt_en: Fix strcpy() warnings in bnxt_ethtool.c
Date: Fri, 10 Aug 2018 14:37:55 -0700 (PDT) [thread overview]
Message-ID: <20180810.143755.680196635901751846.davem@davemloft.net> (raw)
In-Reply-To: <20180810.143545.2102072031329558665.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Fri, 10 Aug 2018 14:35:45 -0700 (PDT)
> From: Michael Chan <michael.chan@broadcom.com>
> Date: Fri, 10 Aug 2018 17:02:12 -0400
>
>> From: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
>>
>> This patch fixes following smatch warnings:
>>
>> drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c:2826 bnxt_fill_coredump_seg_hdr() error: strcpy() '"sEgM"' too large for 'seg_hdr->signature' (5 vs 4)
>> drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c:2858 bnxt_fill_coredump_record() error: strcpy() '"cOrE"' too large for 'record->signature' (5 vs 4)
>> drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c:2879 bnxt_fill_coredump_record() error: strcpy() 'utsname()->sysname' too large for 'record->os_name' (65 vs 32)
>>
>> Fixes: 6c5657d085ae ("bnxt_en: Add support for ethtool get dump.")
>> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>> Signed-off-by: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
>> Signed-off-by: Michael Chan <michael.chan@broadcom.com>
>
> Applied, thanks Michael.
Actually, I'm reverting, this may fix those three warnings, but they are replaced with
a new one:
./include/linux/string.h:246:9: warning: ‘__builtin_strncpy’ output may be truncated copying 32 bytes from a string of length 64 [-Wstringop-truncation]
Sorry.
next prev parent reply other threads:[~2018-08-11 0:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-10 21:02 [PATCH net-next] bnxt_en: Fix strcpy() warnings in bnxt_ethtool.c Michael Chan
2018-08-10 21:35 ` David Miller
2018-08-10 21:37 ` David Miller [this message]
2018-08-10 22:01 ` Michael Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180810.143755.680196635901751846.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dan.carpenter@oracle.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=vasundhara-v.volam@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox