From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next v2] bnxt_en: Fix strcpy() warnings in bnxt_ethtool.c Date: Fri, 10 Aug 2018 19:13:08 -0700 (PDT) Message-ID: <20180810.191308.115506586665540539.davem@davemloft.net> References: <1533939883-23768-1-git-send-email-michael.chan@broadcom.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, dan.carpenter@oracle.com, vasundhara-v.volam@broadcom.com To: michael.chan@broadcom.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:33196 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725882AbeHKEpf (ORCPT ); Sat, 11 Aug 2018 00:45:35 -0400 In-Reply-To: <1533939883-23768-1-git-send-email-michael.chan@broadcom.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Michael Chan Date: Fri, 10 Aug 2018 18:24:43 -0400 > From: Vasundhara Volam > > This patch fixes following smatch warnings: > > drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c:2826 bnxt_fill_coredump_seg_hdr() error: strcpy() '"sEgM"' too large for 'seg_hdr->signature' (5 vs 4) > drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c:2858 bnxt_fill_coredump_record() error: strcpy() '"cOrE"' too large for 'record->signature' (5 vs 4) > drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c:2879 bnxt_fill_coredump_record() error: strcpy() 'utsname()->sysname' too large for 'record->os_name' (65 vs 32) > > Fixes: 6c5657d085ae ("bnxt_en: Add support for ethtool get dump.") > Reported-by: Dan Carpenter > Signed-off-by: Vasundhara Volam > Signed-off-by: Michael Chan That seems to make them all go away, applied, thanks!