From: David Miller <davem@davemloft.net>
To: saeedm@mellanox.com
Cc: netdev@vger.kernel.org
Subject: Re: [net-next 01/12] net/mlx5e: Ethtool steering flow validation refactoring
Date: Fri, 10 Aug 2018 19:22:40 -0700 (PDT) [thread overview]
Message-ID: <20180810.192240.1330017327573643390.davem@davemloft.net> (raw)
In-Reply-To: <20180810222630.11688-2-saeedm@mellanox.com>
From: Saeed Mahameed <saeedm@mellanox.com>
Date: Fri, 10 Aug 2018 15:26:19 -0700
> +static int validate_tcpudp4(struct ethtool_rx_flow_spec *fs)
> +{
> + struct ethtool_tcpip4_spec *l4_mask = &fs->m_u.tcp_ip4_spec;
> + int ntuples = 0;
> +
> + if (fs->m_u.tcp_ip4_spec.tos)
^^^^^^^^^^^^^^^^^^^^^^^^
Since you've gone to the trouble of loading this object into
l4_mask before this statement, please use "if (l4_mask->tos)"
I know you're just moving existing code into a function, but it
looks silly now.
next prev parent reply other threads:[~2018-08-11 4:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-10 22:26 [pull request][net-next 00/12] Mellanox, mlx5e updates 2018-08-10 Saeed Mahameed
2018-08-10 22:26 ` [net-next 01/12] net/mlx5e: Ethtool steering flow validation refactoring Saeed Mahameed
2018-08-11 2:22 ` David Miller [this message]
2018-08-10 22:26 ` [net-next 02/12] net/mlx5e: Ethtool steering flow parsing refactoring Saeed Mahameed
2018-08-10 22:26 ` [net-next 03/12] net/mlx5e: Ethtool steering, ip6 support Saeed Mahameed
2018-08-11 2:25 ` David Miller
2018-08-11 11:53 ` Or Gerlitz
2018-08-10 22:26 ` [net-next 04/12] net/mlx5e: Ethtool steering, l4 proto support Saeed Mahameed
2018-08-10 22:26 ` [net-next 05/12] net/mlx5e: Ethtool steering, move ethtool callbacks Saeed Mahameed
2018-08-10 22:26 ` [net-next 06/12] net/mlx5e: Add CONFIG_MLX5_EN_RXNFC for ethtool rx nfc Saeed Mahameed
2018-08-10 22:26 ` [net-next 07/12] net/mlx5e: Add CONFIG_MLX5_EN_ARFS for accelerated flow steering support Saeed Mahameed
2018-08-10 22:26 ` [net-next 08/12] net/mlx5e: Move flow steering declarations into en/fs.h Saeed Mahameed
2018-08-10 22:26 ` [net-next 09/12] net/mlx5e: vxlan.c depends on CONFIG_VXLAN Saeed Mahameed
2018-08-10 22:26 ` [net-next 10/12] net/mlx5e: clock.c depends on CONFIG_PTP_1588_CLOCK Saeed Mahameed
2018-08-10 22:26 ` [net-next 11/12] net/mlx5: Reorganize the makefile Saeed Mahameed
2018-08-10 22:26 ` [net-next 12/12] net/mlx5: Improve argument name for add flow API Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180810.192240.1330017327573643390.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).