From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ido Schimmel <idosch@mellanox.com>
Subject: Re: [PATCH net-next] mlxsw: core: remove unnecessary function
 mlxsw_core_driver_put
Date: Fri, 10 Aug 2018 18:26:31 +0300
Message-ID: <20180810152631.GB11917@splinter.mtl.com>
References: <20180810023730.13140-1-yuehaibing@huawei.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: davem@davemloft.net, jiri@mellanox.com,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org
To: YueHaibing <yuehaibing@huawei.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-eopbgr60044.outbound.protection.outlook.com ([40.107.6.44]:54192
        "EHLO EUR04-DB3-obe.outbound.protection.outlook.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1727404AbeHJR5j (ORCPT <rfc822;netdev@vger.kernel.org>);
        Fri, 10 Aug 2018 13:57:39 -0400
Content-Disposition: inline
In-Reply-To: <20180810023730.13140-1-yuehaibing@huawei.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Fri, Aug 10, 2018 at 10:37:30AM +0800, YueHaibing wrote:
> The function mlxsw_core_driver_put only traverse mlxsw_core_driver_list
> to find the matched mlxsw_driver,but never used it.
> So it can be removed safely.
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Reviewed-by: Ido Schimmel <idosch@mellanox.com>

FWIW, this function used to call module_put(), but it was removed in
commit 1d20d23c59c9 ("mlxsw: Move PCI id table definitions into driver
modules").

Thanks!