From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] net: dp83640: Mark expected switch fall-throughs Date: Sat, 11 Aug 2018 11:28:53 -0700 (PDT) Message-ID: <20180811.112853.2039117789072425372.davem@davemloft.net> References: <20180809150824.GA15116@embeddedor.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: richardcochran@gmail.com, andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: gustavo@embeddedor.com Return-path: In-Reply-To: <20180809150824.GA15116@embeddedor.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: "Gustavo A. R. Silva" Date: Thu, 9 Aug 2018 10:08:24 -0500 > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Notice that in this particular case, I replaced the code comment at the > top of the switch statement with a proper "fall through" annotation for > each case, which is what GCC is expecting to find. > > Addresses-Coverity-ID: 1056542 ("Missing break in switch") > Addresses-Coverity-ID: 1339579 ("Missing break in switch") > Addresses-Coverity-ID: 1369526 ("Missing break in switch") > Signed-off-by: Gustavo A. R. Silva Applied, thanks.