From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next 0/4] new mechanism to ACK immediately Date: Sat, 11 Aug 2018 11:41:53 -0700 (PDT) Message-ID: <20180811.114153.663666446120670168.davem@davemloft.net> References: <20180809163812.58365-1-ycheng@google.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: edumazet@google.com, netdev@vger.kernel.org, ncardwell@google.com, brakmo@fb.com, weiwan@google.com To: ycheng@google.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:46494 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727348AbeHKWfn (ORCPT ); Sat, 11 Aug 2018 18:35:43 -0400 In-Reply-To: <20180809163812.58365-1-ycheng@google.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Yuchung Cheng Date: Thu, 9 Aug 2018 09:38:08 -0700 > This patch is a follow-up feature improvement to the recent fixes on > the performance issues in ECN (delayed) ACKs. Many of the fixes use > tcp_enter_quickack_mode routine to force immediate ACKs. However the > routine also reset tracking interactive session. This is not ideal > because these immediate ACKs are required by protocol specifics > unrelated to the interactiveness nature of the application. > > This patch set introduces a new flag to send a one-time immediate ACK > without changing the status of interactive session tracking. With this > patch set the immediate ACKs are generated upon these protocol states: > > 1) When a hole is repaired > 2) When CE status changes between subsequent data packets received > 3) When a data packet carries CWR flag This looks really nice, series applied. Thanks!