From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next v2 00/15] Remove rtnl lock dependency from all action implementations Date: Sat, 11 Aug 2018 12:38:00 -0700 (PDT) Message-ID: <20180811.123800.344500398743509604.davem@davemloft.net> References: <1533923515-5664-1-git-send-email-vladbu@mellanox.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, pablo@netfilter.org, kadlec@blackhole.kfki.hu, fw@strlen.de, ast@kernel.org, daniel@iogearbox.net, edumazet@google.com, keescook@chromium.org, marcelo.leitner@gmail.com To: vladbu@mellanox.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:46450 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727445AbeHKWam (ORCPT ); Sat, 11 Aug 2018 18:30:42 -0400 In-Reply-To: <1533923515-5664-1-git-send-email-vladbu@mellanox.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Vlad Buslov Date: Fri, 10 Aug 2018 20:51:40 +0300 > The goal of this change is to update specific actions APIs that access > action private state directly, in order to be independent from external > locking. General approach is to re-use existing tcf_lock spinlock (used > by some action implementation to synchronize control path with data > path) to protect action private state from concurrent modification. If > action has rcu-protected pointer, tcf spinlock is used to protect its > update code, instead of relying on rtnl lock. > > Some actions need to determine rtnl mutex status in order to release it. > For example, ife action can load additional kernel modules(meta ops) and > must make sure that no locks are held during module load. In such cases > 'rtnl_held' argument is used to conditionally release rtnl mutex. ... I like these changes, nice work. If there are any bugs or whatever, we can fix them on top. Series applied to net-next, thanks.