From: Andrew Lunn <andrew@lunn.ch>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH] of: mdio: Support fixed links in of_phy_get_and_connect()
Date: Sun, 12 Aug 2018 19:24:14 +0200 [thread overview]
Message-ID: <20180812172414.GC5354@lunn.ch> (raw)
In-Reply-To: <CACRpkdb_moz2076y2Wcu88BqEOuKkKvj4seZt+-1v0+LYbaW8w@mail.gmail.com>
> It's confusing, I guess these PHY's don't come and go
> very much so the plug/play part isn't really exercised.
Very true. We sometimes need to handle -EPROBE_DEFER, which is not too
different from hot-plugging PHYs. Also, SFP modules are hot-pluggable,
and can contain a copper PHY. However, SFP modules don't have a
traditional MIDO bus. MDIO is tunnelled over i2c. So when a copper SFP
module is hotplugged, the MDIO bus is hot plugged as well.
If you do decided to make any changes here, please ask Russell King to
test, otherwise you might break this use case.
Andrew
next prev parent reply other threads:[~2018-08-12 20:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 17:45 [PATCH] of: mdio: Support fixed links in of_phy_get_and_connect() Linus Walleij
2018-07-11 20:04 ` Andrew Lunn
2018-08-12 11:54 ` Linus Walleij
2018-08-12 17:24 ` Andrew Lunn [this message]
2018-07-14 1:25 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180812172414.GC5354@lunn.ch \
--to=andrew@lunn.ch \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).