From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next v2] cpumask: make cpumask_next_wrap available without smp Date: Mon, 13 Aug 2018 08:58:49 -0700 (PDT) Message-ID: <20180813.085849.2269837466744759310.davem@davemloft.net> References: <20180812131403.123852-1-willemdebruijn.kernel@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, caleb.raitto@gmail.com, lkp@intel.com, willemb@google.com To: willemdebruijn.kernel@gmail.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:53012 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728509AbeHMSlj (ORCPT ); Mon, 13 Aug 2018 14:41:39 -0400 In-Reply-To: <20180812131403.123852-1-willemdebruijn.kernel@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Willem de Bruijn Date: Sun, 12 Aug 2018 09:14:03 -0400 > From: Willem de Bruijn > > The kbuild robot shows build failure on machines without CONFIG_SMP: > > drivers/net/virtio_net.c:1916:10: error: > implicit declaration of function 'cpumask_next_wrap' > > cpumask_next_wrap is exported from lib/cpumask.o, which has > > lib-$(CONFIG_SMP) += cpumask.o > > same as other functions, also define it as static inline in the > NR_CPUS==1 branch in include/linux/cpumask.h. > > If wrap is true and next == start, return nr_cpumask_bits, or 1. > Else wrap across the range of valid cpus, here [0]. > > Fixes: 2ca653d607ce ("virtio_net: Stripe queue affinities across cores.") > Signed-off-by: Willem de Bruijn Applied, thanks Willem.