From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 2/2] net: lan743x: fix building without CONFIG_PTP_1588_CLOCK Date: Mon, 13 Aug 2018 20:44:20 -0700 (PDT) Message-ID: <20180813.204420.1246202084626536095.davem@davemloft.net> References: <20180813211938.2375199-1-arnd@arndb.de> <20180813211938.2375199-2-arnd@arndb.de> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: bryan.whitehead@microchip.com, UNGLinuxDriver@microchip.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: arnd@arndb.de Return-path: In-Reply-To: <20180813211938.2375199-2-arnd@arndb.de> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Arnd Bergmann Date: Mon, 13 Aug 2018 23:19:22 +0200 > Building without CONFIG_PTP_1588_CLOCK results in multiple failures, > this was obviously not well tested: ... > Those #ifdef checks are hard to get right, replace them all with > IS_ENABLED() checks that leave the same code visible to the compiler > but let it optimize out the unused bits based on the configuration. > > Fixes: 07624df1c9ef ("lan743x: lan743x: Add PTP support") > Signed-off-by: Arnd Bergmann Applied.