From: David Miller <davem@davemloft.net>
To: arnd@arndb.de
Cc: jchapman@katalix.com, g.nault@alphalink.fr,
lorenzo.bianconi@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] l2tp: fix unused function warning
Date: Mon, 13 Aug 2018 20:46:37 -0700 (PDT) [thread overview]
Message-ID: <20180813.204637.1084503075030488749.davem@davemloft.net> (raw)
In-Reply-To: <20180813214341.3333789-1-arnd@arndb.de>
From: Arnd Bergmann <arnd@arndb.de>
Date: Mon, 13 Aug 2018 23:43:05 +0200
> Removing one of the callers of pppol2tp_session_get_sock caused a harmless
> warning in some configurations:
>
> net/l2tp/l2tp_ppp.c:142:21: 'pppol2tp_session_get_sock' defined but not used [-Wunused-function]
>
> Rather than adding another #ifdef here, using a proper IS_ENABLED()
> check makes the code more readable and avoids those warnings while
> letting the compiler figure out for itself which code is needed.
>
> This adds one pointer for the unused show() callback in struct
> l2tp_session, but that seems harmless.
>
> Fixes: b0e29063dcb3 ("l2tp: remove pppol2tp_session_ioctl()")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied.
prev parent reply other threads:[~2018-08-14 3:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-13 21:43 [PATCH] l2tp: fix unused function warning Arnd Bergmann
2018-08-14 3:46 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180813.204637.1084503075030488749.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arnd@arndb.de \
--cc=g.nault@alphalink.fr \
--cc=jchapman@katalix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).