From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] net: stmmac: mark PM functions as __maybe_unused Date: Mon, 13 Aug 2018 20:46:45 -0700 (PDT) Message-ID: <20180813.204645.1525930340958396833.davem@davemloft.net> References: <20180813215046.3663828-1-arnd@arndb.de> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: peppe.cavallaro@st.com, alexandre.torgue@st.com, joabreu@synopsys.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: arnd@arndb.de Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:38194 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725999AbeHNGb7 (ORCPT ); Tue, 14 Aug 2018 02:31:59 -0400 In-Reply-To: <20180813215046.3663828-1-arnd@arndb.de> Sender: netdev-owner@vger.kernel.org List-ID: From: Arnd Bergmann Date: Mon, 13 Aug 2018 23:50:41 +0200 > The newly added suspend/resume functions cause a build warning > when CONFIG_PM is disabled: > > drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c:324:12: error: 'stmmac_pci_resume' defined but not used [-Werror=unused-function] > drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c:306:12: error: 'stmmac_pci_suspend' defined but not used [-Werror=unused-function] > > Mark them as __maybe_unused so gcc can drop them silently. > > Fixes: b7d0f08e9129 ("net: stmmac: Fix WoL for PCI-based setups") > Signed-off-by: Arnd Bergmann Applied.