From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] net: systemport: fix unused function warning Date: Mon, 13 Aug 2018 20:46:51 -0700 (PDT) Message-ID: <20180813.204651.82890800816549610.davem@davemloft.net> References: <20180813221041.219857-1-arnd@arndb.de> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: f.fainelli@gmail.com, talgi@mellanox.com, alexander.h.duyck@intel.com, jeffrey.t.kirsher@intel.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: arnd@arndb.de Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:38206 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725999AbeHNGcG (ORCPT ); Tue, 14 Aug 2018 02:32:06 -0400 In-Reply-To: <20180813221041.219857-1-arnd@arndb.de> Sender: netdev-owner@vger.kernel.org List-ID: From: Arnd Bergmann Date: Tue, 14 Aug 2018 00:10:34 +0200 > The only remaining caller of this function is inside of an #ifdef > after another caller got removed. This causes a harmless warning > in some configurations: > > drivers/net/ethernet/broadcom/bcmsysport.c:1068:13: error: 'bcm_sysport_resume_from_wol' defined but not used [-Werror=unused-function] > > Removing the #ifdef around the PM functions simplifies the code > and avoids the problem but letting the compiler drop the unused > functions silently. > > Fixes: 9e85e22713d6 ("net: systemport: Do not re-configure upon WoL interrupt") > Signed-off-by: Arnd Bergmann Applied.