From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] bnxt_en: take coredump_record structure off stack Date: Mon, 13 Aug 2018 20:46:57 -0700 (PDT) Message-ID: <20180813.204657.372870473276503588.davem@davemloft.net> References: <20180813221256.299221-1-arnd@arndb.de> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: michael.chan@broadcom.com, vasundhara-v.volam@broadcom.com, gospo@broadcom.com, scott.branden@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: arnd@arndb.de Return-path: In-Reply-To: <20180813221256.299221-1-arnd@arndb.de> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Arnd Bergmann Date: Tue, 14 Aug 2018 00:12:45 +0200 > The bnxt_coredump_record structure is very long, causing a warning > about possible stack overflow on 32-bit architectures: > > drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c: In function 'bnxt_get_coredump': > drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c:2989:1: error: the frame size of 1188 bytes is larger than 1024 bytes [-Werror=frame-larger-than=] > > I could not see any reason to operate on an on-stack copy of the > structure before copying it back into the caller-provided buffer, which > also simplifies the code here. > > Fixes: 6c5657d085ae ("bnxt_en: Add support for ethtool get dump.") > Signed-off-by: Arnd Bergmann Applied.