* [PATCH] rds: fix building with IPV6=m
@ 2018-08-14 9:07 Arnd Bergmann
2018-08-14 16:53 ` Santosh Shilimkar
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Arnd Bergmann @ 2018-08-14 9:07 UTC (permalink / raw)
To: Santosh Shilimkar, David S. Miller
Cc: Arnd Bergmann, Anders Roxell, Greg Thelen, Ka-Cheong Poon,
Stephen Hemminger, netdev, linux-rdma, rds-devel, linux-kernel
When CONFIG_RDS_TCP is built-in and CONFIG_IPV6 is a loadable
module, we get a link error agains the modular ipv6_chk_addr()
function:
net/rds/tcp.o: In function `rds_tcp_laddr_check':
tcp.c:(.text+0x3b2): undefined reference to `ipv6_chk_addr'
This adds back a dependency that forces RDS_TCP to also be
a loadable module when IPV6 is one.
Fixes: e65d4d96334e ("rds: Remove IPv6 dependency")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
net/rds/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/rds/Kconfig b/net/rds/Kconfig
index 41f75563b54b..01b3bd6a3708 100644
--- a/net/rds/Kconfig
+++ b/net/rds/Kconfig
@@ -16,6 +16,7 @@ config RDS_RDMA
config RDS_TCP
tristate "RDS over TCP"
depends on RDS
+ depends on IPV6 || !IPV6
---help---
Allow RDS to use TCP as a transport.
This transport does not support RDMA operations.
--
2.18.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] rds: fix building with IPV6=m
2018-08-14 9:07 [PATCH] rds: fix building with IPV6=m Arnd Bergmann
@ 2018-08-14 16:53 ` Santosh Shilimkar
2018-08-14 17:06 ` David Miller
2018-08-14 19:15 ` Greg Thelen
2 siblings, 0 replies; 4+ messages in thread
From: Santosh Shilimkar @ 2018-08-14 16:53 UTC (permalink / raw)
To: Arnd Bergmann, David S. Miller
Cc: Anders Roxell, Greg Thelen, Ka-Cheong Poon, Stephen Hemminger,
netdev, linux-rdma, rds-devel, linux-kernel
On 8/14/2018 2:07 AM, Arnd Bergmann wrote:
> When CONFIG_RDS_TCP is built-in and CONFIG_IPV6 is a loadable
> module, we get a link error agains the modular ipv6_chk_addr()
> function:
>
> net/rds/tcp.o: In function `rds_tcp_laddr_check':
> tcp.c:(.text+0x3b2): undefined reference to `ipv6_chk_addr'
>
> This adds back a dependency that forces RDS_TCP to also be
> a loadable module when IPV6 is one.
>
> Fixes: e65d4d96334e ("rds: Remove IPv6 dependency")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> net/rds/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/rds/Kconfig b/net/rds/Kconfig
> index 41f75563b54b..01b3bd6a3708 100644
> --- a/net/rds/Kconfig
> +++ b/net/rds/Kconfig
> @@ -16,6 +16,7 @@ config RDS_RDMA
> config RDS_TCP
> tristate "RDS over TCP"
> depends on RDS
> + depends on IPV6 || !IPV6
> ---help---
> Allow RDS to use TCP as a transport.
> This transport does not support RDMA operations.
>
Its weird depends on but probably ok since we get to module
to be enabled with or without IPV6.
Thanks for the patch Arnd !!
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] rds: fix building with IPV6=m
2018-08-14 9:07 [PATCH] rds: fix building with IPV6=m Arnd Bergmann
2018-08-14 16:53 ` Santosh Shilimkar
@ 2018-08-14 17:06 ` David Miller
2018-08-14 19:15 ` Greg Thelen
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2018-08-14 17:06 UTC (permalink / raw)
To: arnd
Cc: santosh.shilimkar, anders.roxell, gthelen, ka-cheong.poon,
stephen, netdev, linux-rdma, rds-devel, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Date: Tue, 14 Aug 2018 11:07:42 +0200
> When CONFIG_RDS_TCP is built-in and CONFIG_IPV6 is a loadable
> module, we get a link error agains the modular ipv6_chk_addr()
> function:
>
> net/rds/tcp.o: In function `rds_tcp_laddr_check':
> tcp.c:(.text+0x3b2): undefined reference to `ipv6_chk_addr'
>
> This adds back a dependency that forces RDS_TCP to also be
> a loadable module when IPV6 is one.
>
> Fixes: e65d4d96334e ("rds: Remove IPv6 dependency")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] rds: fix building with IPV6=m
2018-08-14 9:07 [PATCH] rds: fix building with IPV6=m Arnd Bergmann
2018-08-14 16:53 ` Santosh Shilimkar
2018-08-14 17:06 ` David Miller
@ 2018-08-14 19:15 ` Greg Thelen
2 siblings, 0 replies; 4+ messages in thread
From: Greg Thelen @ 2018-08-14 19:15 UTC (permalink / raw)
To: Arnd Bergmann, Santosh Shilimkar, David S. Miller
Cc: Arnd Bergmann, Anders Roxell, Ka-Cheong Poon, Stephen Hemminger,
netdev, linux-rdma, rds-devel, linux-kernel
Arnd Bergmann <arnd@arndb.de> wrote:
> When CONFIG_RDS_TCP is built-in and CONFIG_IPV6 is a loadable
> module, we get a link error agains the modular ipv6_chk_addr()
> function:
>
> net/rds/tcp.o: In function `rds_tcp_laddr_check':
> tcp.c:(.text+0x3b2): undefined reference to `ipv6_chk_addr'
>
> This adds back a dependency that forces RDS_TCP to also be
> a loadable module when IPV6 is one.
>
> Fixes: e65d4d96334e ("rds: Remove IPv6 dependency")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Greg Thelen <gthelenq@google.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-08-14 19:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-14 9:07 [PATCH] rds: fix building with IPV6=m Arnd Bergmann
2018-08-14 16:53 ` Santosh Shilimkar
2018-08-14 17:06 ` David Miller
2018-08-14 19:15 ` Greg Thelen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).