From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: missing unlock on error path Date: Tue, 14 Aug 2018 10:08:25 -0700 (PDT) Message-ID: <20180814.100825.1562962208475355418.davem@davemloft.net> References: <20180814090905.rm6i665c5utl7d32@kili.mountain> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org To: dan.carpenter@oracle.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:52600 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733133AbeHNT40 (ORCPT ); Tue, 14 Aug 2018 15:56:26 -0400 In-Reply-To: <20180814090905.rm6i665c5utl7d32@kili.mountain> Sender: netdev-owner@vger.kernel.org List-ID: From: Dan Carpenter Date: Tue, 14 Aug 2018 12:09:05 +0300 > We added a new error path, but we need to drop the lock before we return. > > Fixes: 2d2e1dd29962 ("net: dsa: mv88e6xxx: Cache the port cmode") > Signed-off-by: Dan Carpenter Applied.