From: David Miller <davem@davemloft.net>
To: tiwai@suse.de
Cc: sthemmin@microsoft.com, kys@microsoft.com,
haiyangz@microsoft.com, devel@linuxdriverproject.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] hv/netvsc: Fix NULL dereference at single queue mode fallback
Date: Tue, 14 Aug 2018 10:29:32 -0700 (PDT) [thread overview]
Message-ID: <20180814.102932.1425242139845133705.davem@davemloft.net> (raw)
In-Reply-To: <20180814171050.26356-1-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
Date: Tue, 14 Aug 2018 19:10:50 +0200
> The recent commit 916c5e1413be ("hv/netvsc: fix handling of fallback
> to single queue mode") tried to fix the fallback behavior to a single
> queue mode, but it changed the function to return zero incorrectly,
> while the function should return an object pointer. Eventually this
> leads to a NULL dereference at the callers that expect non-NULL
> value.
>
> Fix it by returning the proper net_device object.
>
> Fixes: 916c5e1413be ("hv/netvsc: fix handling of fallback to single queue mode")
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Applied and queued up for -stable.
Please do not put explicit "CC: stable" notations in networking patches, I queue
up and submit networking patches to -stable explicitly.
Thank you.
next prev parent reply other threads:[~2018-08-14 20:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-14 17:10 [PATCH] hv/netvsc: Fix NULL dereference at single queue mode fallback Takashi Iwai
2018-08-14 17:18 ` Stephen Hemminger
2018-08-14 17:29 ` David Miller [this message]
2018-08-14 17:47 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180814.102932.1425242139845133705.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=sthemmin@microsoft.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).