* [PATCH v2] net/mlx5: Delete unneeded function argument
@ 2018-08-15 15:08 Yuval Shaia
2018-08-16 6:41 ` Gal Pressman
0 siblings, 1 reply; 4+ messages in thread
From: Yuval Shaia @ 2018-08-15 15:08 UTC (permalink / raw)
To: saeedm, leon, davem, netdev, linux-rdma; +Cc: Yuval Shaia
priv argument is not used by the function, delete it.
Fixes: a89842811ea98 ("net/mlx5e: Merge per priority stats groups")
Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
---
v1 -> v2:
* Remove blank line as pointed by Leon.
---
drivers/net/ethernet/mellanox/mlx5/core/en_stats.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c b/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
index 1646859974ce..4c4d779dafa8 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
@@ -813,7 +813,7 @@ static const struct counter_desc pport_per_prio_traffic_stats_desc[] = {
#define NUM_PPORT_PER_PRIO_TRAFFIC_COUNTERS ARRAY_SIZE(pport_per_prio_traffic_stats_desc)
-static int mlx5e_grp_per_prio_traffic_get_num_stats(struct mlx5e_priv *priv)
+static int mlx5e_grp_per_prio_traffic_get_num_stats(void)
{
return NUM_PPORT_PER_PRIO_TRAFFIC_COUNTERS * NUM_PPORT_PRIO;
}
@@ -971,7 +971,7 @@ static int mlx5e_grp_per_prio_pfc_fill_stats(struct mlx5e_priv *priv,
static int mlx5e_grp_per_prio_get_num_stats(struct mlx5e_priv *priv)
{
- return mlx5e_grp_per_prio_traffic_get_num_stats(priv) +
+ return mlx5e_grp_per_prio_traffic_get_num_stats() +
mlx5e_grp_per_prio_pfc_get_num_stats(priv);
}
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] net/mlx5: Delete unneeded function argument
2018-08-15 15:08 [PATCH v2] net/mlx5: Delete unneeded function argument Yuval Shaia
@ 2018-08-16 6:41 ` Gal Pressman
2018-08-16 9:00 ` Yuval Shaia
0 siblings, 1 reply; 4+ messages in thread
From: Gal Pressman @ 2018-08-16 6:41 UTC (permalink / raw)
To: Yuval Shaia, saeedm, leon, davem, netdev, linux-rdma
On 15-Aug-18 18:08, Yuval Shaia wrote:
> priv argument is not used by the function, delete it.
>
> Fixes: a89842811ea98 ("net/mlx5e: Merge per priority stats groups")
> Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
nit: prefix should be net/mlx5e.
> ---
> v1 -> v2:
> * Remove blank line as pointed by Leon.
> ---
> drivers/net/ethernet/mellanox/mlx5/core/en_stats.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c b/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
> index 1646859974ce..4c4d779dafa8 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
> @@ -813,7 +813,7 @@ static const struct counter_desc pport_per_prio_traffic_stats_desc[] = {
>
> #define NUM_PPORT_PER_PRIO_TRAFFIC_COUNTERS ARRAY_SIZE(pport_per_prio_traffic_stats_desc)
>
> -static int mlx5e_grp_per_prio_traffic_get_num_stats(struct mlx5e_priv *priv)
> +static int mlx5e_grp_per_prio_traffic_get_num_stats(void)
> {
> return NUM_PPORT_PER_PRIO_TRAFFIC_COUNTERS * NUM_PPORT_PRIO;
> }
> @@ -971,7 +971,7 @@ static int mlx5e_grp_per_prio_pfc_fill_stats(struct mlx5e_priv *priv,
>
> static int mlx5e_grp_per_prio_get_num_stats(struct mlx5e_priv *priv)
> {
> - return mlx5e_grp_per_prio_traffic_get_num_stats(priv) +
> + return mlx5e_grp_per_prio_traffic_get_num_stats() +
> mlx5e_grp_per_prio_pfc_get_num_stats(priv);
> }
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] net/mlx5: Delete unneeded function argument
2018-08-16 6:41 ` Gal Pressman
@ 2018-08-16 9:00 ` Yuval Shaia
2018-08-16 10:31 ` Gal Pressman
0 siblings, 1 reply; 4+ messages in thread
From: Yuval Shaia @ 2018-08-16 9:00 UTC (permalink / raw)
To: Gal Pressman; +Cc: saeedm, leon, davem, netdev, linux-rdma
On Thu, Aug 16, 2018 at 09:41:34AM +0300, Gal Pressman wrote:
> On 15-Aug-18 18:08, Yuval Shaia wrote:
> > priv argument is not used by the function, delete it.
> >
> > Fixes: a89842811ea98 ("net/mlx5e: Merge per priority stats groups")
> > Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
>
> nit: prefix should be net/mlx5e.
1. Will do.
2. Why? (asking since dir name is mlx5)
>
> > ---
> > v1 -> v2:
> > * Remove blank line as pointed by Leon.
> > ---
> > drivers/net/ethernet/mellanox/mlx5/core/en_stats.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c b/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
> > index 1646859974ce..4c4d779dafa8 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
> > @@ -813,7 +813,7 @@ static const struct counter_desc pport_per_prio_traffic_stats_desc[] = {
> >
> > #define NUM_PPORT_PER_PRIO_TRAFFIC_COUNTERS ARRAY_SIZE(pport_per_prio_traffic_stats_desc)
> >
> > -static int mlx5e_grp_per_prio_traffic_get_num_stats(struct mlx5e_priv *priv)
> > +static int mlx5e_grp_per_prio_traffic_get_num_stats(void)
> > {
> > return NUM_PPORT_PER_PRIO_TRAFFIC_COUNTERS * NUM_PPORT_PRIO;
> > }
> > @@ -971,7 +971,7 @@ static int mlx5e_grp_per_prio_pfc_fill_stats(struct mlx5e_priv *priv,
> >
> > static int mlx5e_grp_per_prio_get_num_stats(struct mlx5e_priv *priv)
> > {
> > - return mlx5e_grp_per_prio_traffic_get_num_stats(priv) +
> > + return mlx5e_grp_per_prio_traffic_get_num_stats() +
> > mlx5e_grp_per_prio_pfc_get_num_stats(priv);
> > }
> >
> >
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] net/mlx5: Delete unneeded function argument
2018-08-16 9:00 ` Yuval Shaia
@ 2018-08-16 10:31 ` Gal Pressman
0 siblings, 0 replies; 4+ messages in thread
From: Gal Pressman @ 2018-08-16 10:31 UTC (permalink / raw)
To: Yuval Shaia; +Cc: saeedm, leon, davem, netdev, linux-rdma
On 16-Aug-18 12:00, Yuval Shaia wrote:
> On Thu, Aug 16, 2018 at 09:41:34AM +0300, Gal Pressman wrote:
>> On 15-Aug-18 18:08, Yuval Shaia wrote:
>>> priv argument is not used by the function, delete it.
>>>
>>> Fixes: a89842811ea98 ("net/mlx5e: Merge per priority stats groups")
>>> Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
>>
>> nit: prefix should be net/mlx5e.
>
> 1. Will do.
> 2. Why? (asking since dir name is mlx5)
Core related changes use net/mlx5 prefix, Ethernet related changes (en_* files) use net/mlx5e prefix.
Same thought goes into function names prefix (mlx5_*/mlx5e_*).
>
>>
>>> ---
>>> v1 -> v2:
>>> * Remove blank line as pointed by Leon.
>>> ---
>>> drivers/net/ethernet/mellanox/mlx5/core/en_stats.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c b/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
>>> index 1646859974ce..4c4d779dafa8 100644
>>> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
>>> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
>>> @@ -813,7 +813,7 @@ static const struct counter_desc pport_per_prio_traffic_stats_desc[] = {
>>>
>>> #define NUM_PPORT_PER_PRIO_TRAFFIC_COUNTERS ARRAY_SIZE(pport_per_prio_traffic_stats_desc)
>>>
>>> -static int mlx5e_grp_per_prio_traffic_get_num_stats(struct mlx5e_priv *priv)
>>> +static int mlx5e_grp_per_prio_traffic_get_num_stats(void)
>>> {
>>> return NUM_PPORT_PER_PRIO_TRAFFIC_COUNTERS * NUM_PPORT_PRIO;
>>> }
>>> @@ -971,7 +971,7 @@ static int mlx5e_grp_per_prio_pfc_fill_stats(struct mlx5e_priv *priv,
>>>
>>> static int mlx5e_grp_per_prio_get_num_stats(struct mlx5e_priv *priv)
>>> {
>>> - return mlx5e_grp_per_prio_traffic_get_num_stats(priv) +
>>> + return mlx5e_grp_per_prio_traffic_get_num_stats() +
>>> mlx5e_grp_per_prio_pfc_get_num_stats(priv);
>>> }
>>>
>>>
>>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-08-16 13:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-15 15:08 [PATCH v2] net/mlx5: Delete unneeded function argument Yuval Shaia
2018-08-16 6:41 ` Gal Pressman
2018-08-16 9:00 ` Yuval Shaia
2018-08-16 10:31 ` Gal Pressman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).