* [PATCH net-next] r8169: add missing Kconfig dependency
@ 2018-08-17 18:42 Heiner Kallweit
2018-08-17 18:45 ` Florian Fainelli
0 siblings, 1 reply; 3+ messages in thread
From: Heiner Kallweit @ 2018-08-17 18:42 UTC (permalink / raw)
To: David Miller, Realtek linux nic maintainers
Cc: netdev@vger.kernel.org, Florian Fainelli
Now that we switched the r8169 driver to use phylib, there's a
dependency on the Realtek PHY drivers. This dependency was missing
in Kconfig.
Reported-by: Jouni Mettälä <jtmettala@gmail.com>
Fixes: f1e911d5d0df ("r8169: add basic phylib support")
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/net/ethernet/realtek/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/realtek/Kconfig b/drivers/net/ethernet/realtek/Kconfig
index e1cd934c2..96d1b9c08 100644
--- a/drivers/net/ethernet/realtek/Kconfig
+++ b/drivers/net/ethernet/realtek/Kconfig
@@ -100,6 +100,7 @@ config R8169
select FW_LOADER
select CRC32
select PHYLIB
+ select REALTEK_PHY
---help---
Say Y here if you have a Realtek 8169 PCI Gigabit Ethernet adapter.
--
2.18.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] r8169: add missing Kconfig dependency
2018-08-17 18:42 [PATCH net-next] r8169: add missing Kconfig dependency Heiner Kallweit
@ 2018-08-17 18:45 ` Florian Fainelli
2018-08-17 19:25 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Florian Fainelli @ 2018-08-17 18:45 UTC (permalink / raw)
To: Heiner Kallweit, David Miller, Realtek linux nic maintainers
Cc: netdev@vger.kernel.org
On 08/17/2018 11:42 AM, Heiner Kallweit wrote:
> Now that we switched the r8169 driver to use phylib, there's a
> dependency on the Realtek PHY drivers. This dependency was missing
> in Kconfig.
>
> Reported-by: Jouni Mettälä <jtmettala@gmail.com>
> Fixes: f1e911d5d0df ("r8169: add basic phylib support")
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
This is probably targeting 'net' now that the changes landed in Linus' tree:
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] r8169: add missing Kconfig dependency
2018-08-17 18:45 ` Florian Fainelli
@ 2018-08-17 19:25 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2018-08-17 19:25 UTC (permalink / raw)
To: f.fainelli; +Cc: hkallweit1, nic_swsd, netdev
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Fri, 17 Aug 2018 11:45:57 -0700
> On 08/17/2018 11:42 AM, Heiner Kallweit wrote:
>> Now that we switched the r8169 driver to use phylib, there's a
>> dependency on the Realtek PHY drivers. This dependency was missing
>> in Kconfig.
>>
>> Reported-by: Jouni Mettälä <jtmettala@gmail.com>
>> Fixes: f1e911d5d0df ("r8169: add basic phylib support")
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>
> This is probably targeting 'net' now that the changes landed in Linus' tree:
Right.
> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Applied, thanks everyone.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-17 22:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-17 18:42 [PATCH net-next] r8169: add missing Kconfig dependency Heiner Kallweit
2018-08-17 18:45 ` Florian Fainelli
2018-08-17 19:25 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).