From: Roman Gushchin <guro@fb.com>
To: Yonghong Song <yhs@fb.com>
Cc: <ast@fb.com>, <daniel@iogearbox.net>, <netdev@vger.kernel.org>,
<kernel-team@fb.com>
Subject: Re: [PATCH bpf] tools/bpf: fix bpf selftest test_cgroup_storage failure
Date: Fri, 17 Aug 2018 08:59:39 -0700 [thread overview]
Message-ID: <20180817155936.GA1906@castle> (raw)
In-Reply-To: <20180817155415.3357915-1-yhs@fb.com>
On Fri, Aug 17, 2018 at 08:54:15AM -0700, Yonghong Song wrote:
> The bpf selftest test_cgroup_storage failed in one of
> our production test servers.
> # sudo ./test_cgroup_storage
> Failed to create map: Operation not permitted
>
> It turns out this is due to insufficient locked memory
> with system default 16KB.
>
> Similar to other self tests, let us arm the process
> with unlimited locked memory. With this change,
> the test passed.
> # sudo ./test_cgroup_storage
> test_cgroup_storage:PASS
>
> Fixes: 68cfa3ac6b8d ("selftests/bpf: add a cgroup storage test")
> Cc: Roman Gushchin <guro@fb.com>
> Signed-off-by: Yonghong Song <yhs@fb.com>
> ---
> tools/testing/selftests/bpf/test_cgroup_storage.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/bpf/test_cgroup_storage.c b/tools/testing/selftests/bpf/test_cgroup_storage.c
> index dc83fb2d3f27..4e196e3bfecf 100644
> --- a/tools/testing/selftests/bpf/test_cgroup_storage.c
> +++ b/tools/testing/selftests/bpf/test_cgroup_storage.c
> @@ -5,6 +5,7 @@
> #include <stdio.h>
> #include <stdlib.h>
>
> +#include "bpf_rlimit.h"
> #include "cgroup_helpers.h"
>
> char bpf_log_buf[BPF_LOG_BUF_SIZE];
> --
> 2.17.1
>
Acked-by: Roman Gushchin <guro@fb.com>
Thank you, Yonghong!
next prev parent reply other threads:[~2018-08-17 19:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-17 15:54 [PATCH bpf] tools/bpf: fix bpf selftest test_cgroup_storage failure Yonghong Song
2018-08-17 15:59 ` Roman Gushchin [this message]
2018-08-17 19:26 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180817155936.GA1906@castle \
--to=guro@fb.com \
--cc=ast@fb.com \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).