* [PATCH bpf] tools/bpf: fix bpf selftest test_cgroup_storage failure
@ 2018-08-17 15:54 Yonghong Song
2018-08-17 15:59 ` Roman Gushchin
2018-08-17 19:26 ` Alexei Starovoitov
0 siblings, 2 replies; 3+ messages in thread
From: Yonghong Song @ 2018-08-17 15:54 UTC (permalink / raw)
To: ast, daniel, netdev; +Cc: kernel-team, Roman Gushchin
The bpf selftest test_cgroup_storage failed in one of
our production test servers.
# sudo ./test_cgroup_storage
Failed to create map: Operation not permitted
It turns out this is due to insufficient locked memory
with system default 16KB.
Similar to other self tests, let us arm the process
with unlimited locked memory. With this change,
the test passed.
# sudo ./test_cgroup_storage
test_cgroup_storage:PASS
Fixes: 68cfa3ac6b8d ("selftests/bpf: add a cgroup storage test")
Cc: Roman Gushchin <guro@fb.com>
Signed-off-by: Yonghong Song <yhs@fb.com>
---
tools/testing/selftests/bpf/test_cgroup_storage.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/bpf/test_cgroup_storage.c b/tools/testing/selftests/bpf/test_cgroup_storage.c
index dc83fb2d3f27..4e196e3bfecf 100644
--- a/tools/testing/selftests/bpf/test_cgroup_storage.c
+++ b/tools/testing/selftests/bpf/test_cgroup_storage.c
@@ -5,6 +5,7 @@
#include <stdio.h>
#include <stdlib.h>
+#include "bpf_rlimit.h"
#include "cgroup_helpers.h"
char bpf_log_buf[BPF_LOG_BUF_SIZE];
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH bpf] tools/bpf: fix bpf selftest test_cgroup_storage failure
2018-08-17 15:54 [PATCH bpf] tools/bpf: fix bpf selftest test_cgroup_storage failure Yonghong Song
@ 2018-08-17 15:59 ` Roman Gushchin
2018-08-17 19:26 ` Alexei Starovoitov
1 sibling, 0 replies; 3+ messages in thread
From: Roman Gushchin @ 2018-08-17 15:59 UTC (permalink / raw)
To: Yonghong Song; +Cc: ast, daniel, netdev, kernel-team
On Fri, Aug 17, 2018 at 08:54:15AM -0700, Yonghong Song wrote:
> The bpf selftest test_cgroup_storage failed in one of
> our production test servers.
> # sudo ./test_cgroup_storage
> Failed to create map: Operation not permitted
>
> It turns out this is due to insufficient locked memory
> with system default 16KB.
>
> Similar to other self tests, let us arm the process
> with unlimited locked memory. With this change,
> the test passed.
> # sudo ./test_cgroup_storage
> test_cgroup_storage:PASS
>
> Fixes: 68cfa3ac6b8d ("selftests/bpf: add a cgroup storage test")
> Cc: Roman Gushchin <guro@fb.com>
> Signed-off-by: Yonghong Song <yhs@fb.com>
> ---
> tools/testing/selftests/bpf/test_cgroup_storage.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/bpf/test_cgroup_storage.c b/tools/testing/selftests/bpf/test_cgroup_storage.c
> index dc83fb2d3f27..4e196e3bfecf 100644
> --- a/tools/testing/selftests/bpf/test_cgroup_storage.c
> +++ b/tools/testing/selftests/bpf/test_cgroup_storage.c
> @@ -5,6 +5,7 @@
> #include <stdio.h>
> #include <stdlib.h>
>
> +#include "bpf_rlimit.h"
> #include "cgroup_helpers.h"
>
> char bpf_log_buf[BPF_LOG_BUF_SIZE];
> --
> 2.17.1
>
Acked-by: Roman Gushchin <guro@fb.com>
Thank you, Yonghong!
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH bpf] tools/bpf: fix bpf selftest test_cgroup_storage failure
2018-08-17 15:54 [PATCH bpf] tools/bpf: fix bpf selftest test_cgroup_storage failure Yonghong Song
2018-08-17 15:59 ` Roman Gushchin
@ 2018-08-17 19:26 ` Alexei Starovoitov
1 sibling, 0 replies; 3+ messages in thread
From: Alexei Starovoitov @ 2018-08-17 19:26 UTC (permalink / raw)
To: Yonghong Song; +Cc: ast, daniel, netdev, kernel-team, Roman Gushchin
On Fri, Aug 17, 2018 at 08:54:15AM -0700, Yonghong Song wrote:
> The bpf selftest test_cgroup_storage failed in one of
> our production test servers.
> # sudo ./test_cgroup_storage
> Failed to create map: Operation not permitted
>
> It turns out this is due to insufficient locked memory
> with system default 16KB.
>
> Similar to other self tests, let us arm the process
> with unlimited locked memory. With this change,
> the test passed.
> # sudo ./test_cgroup_storage
> test_cgroup_storage:PASS
>
> Fixes: 68cfa3ac6b8d ("selftests/bpf: add a cgroup storage test")
> Cc: Roman Gushchin <guro@fb.com>
> Signed-off-by: Yonghong Song <yhs@fb.com>
Applied, Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-17 22:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-17 15:54 [PATCH bpf] tools/bpf: fix bpf selftest test_cgroup_storage failure Yonghong Song
2018-08-17 15:59 ` Roman Gushchin
2018-08-17 19:26 ` Alexei Starovoitov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).