From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: Peter Robinson <pbrobinson@gmail.com>,
Marc Haber <mh+netdev@zugschlus.de>,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
labbott@redhat.com, Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [offlist] Re: Crash in netlink/sk_filter_trim_cap on ARMv7 on 4.18rc1
Date: Fri, 17 Aug 2018 17:17:43 +0100 [thread overview]
Message-ID: <20180817161743.GX30658@n2100.armlinux.org.uk> (raw)
In-Reply-To: <1c2218cb-63bf-1528-6156-8ce93f46169c@iogearbox.net>
On Fri, Aug 17, 2018 at 02:40:19PM +0200, Daniel Borkmann wrote:
> I'd have one potential bug suspicion, for the 4.18 one you were trying,
> could you run with the below patch to see whether it would help?
I think this is almost certainly the problem - looking at the history,
it seems that the "-4" was assumed to be part of the scratch stuff in
commit 38ca93060163 ("bpf, arm32: save 4 bytes of unneeded stack space")
but it isn't - it's because "off" of zero refers to the top word in the
stack (iow at STACK_SIZE-4).
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 13.8Mbps down 630kbps up
According to speedtest.net: 13Mbps down 490kbps up
next prev parent reply other threads:[~2018-08-17 19:21 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-22 11:19 Crash in netlink/sk_filter_trim_cap on ARMv7 on 4.18rc1 Peter Robinson
2018-06-22 12:55 ` Eric Dumazet
2018-06-24 9:24 ` Peter Robinson
2018-06-25 8:48 ` Daniel Borkmann
2018-06-25 12:03 ` Peter Robinson
[not found] ` <ad98d60c-bd60-b495-c4bd-507fc29c8bcd@iogearbox.net>
[not found] ` <CALeDE9PBZWJBp8KB0mB4zoNXqscmzxWzz+LnuqRA-z4t1e9T8g@mail.gmail.com>
2018-06-25 16:41 ` [offlist] " Peter Robinson
2018-06-26 12:23 ` Peter Robinson
2018-06-26 12:52 ` Daniel Borkmann
2018-07-04 7:33 ` Peter Robinson
2018-07-04 23:10 ` Daniel Borkmann
2018-07-04 23:41 ` Russell King - ARM Linux
2018-07-05 7:31 ` Russell King - ARM Linux
2018-07-05 7:46 ` Daniel Borkmann
2018-08-16 20:35 ` Marc Haber
2018-08-16 22:58 ` Russell King - ARM Linux
2018-08-17 12:25 ` Peter Robinson
2018-08-17 12:40 ` Daniel Borkmann
2018-08-17 14:32 ` Peter Robinson
2018-08-17 16:17 ` Russell King - ARM Linux [this message]
2018-08-17 18:30 ` Daniel Borkmann
2018-08-17 18:51 ` Stefan Wahren
2018-08-17 21:15 ` Peter Robinson
2018-08-17 21:13 ` Peter Robinson
2018-08-17 22:06 ` Daniel Borkmann
2018-08-17 21:12 ` Peter Robinson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180817161743.GX30658@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=daniel@iogearbox.net \
--cc=eric.dumazet@gmail.com \
--cc=labbott@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mh+netdev@zugschlus.de \
--cc=netdev@vger.kernel.org \
--cc=pbrobinson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).