From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: [endianness bug] cxgb4: mk_act_open_req() buggers ->{local,peer}_ip on big-endian hosts Date: Fri, 17 Aug 2018 19:58:41 +0100 Message-ID: <20180817185841.GF6515@ZenIV.linux.org.uk> References: <20180805172238.GH15082@ZenIV.linux.org.uk> <20180806121459.GA5591@chelsio.com> <20180814212524.GT6515@ZenIV.linux.org.uk> <20180817130536.GA31768@chelsio.com> <20180817154320.GD6515@ZenIV.linux.org.uk> <20180817180949.GE6515@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Rahul Lakkireddy , David Miller , "netdev@vger.kernel.org" To: Ganesh Goudar Return-path: Received: from zeniv.linux.org.uk ([195.92.253.2]:54466 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727825AbeHQWDQ (ORCPT ); Fri, 17 Aug 2018 18:03:16 -0400 Content-Disposition: inline In-Reply-To: <20180817180949.GE6515@ZenIV.linux.org.uk> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, Aug 17, 2018 at 07:09:49PM +0100, Al Viro wrote: > Re that code - are you sure it doesn't need le64_to_cpu(*src)? Because from what > I understand about PCI (which matches just fine to the comments in the same driver), > you probably do need that. Again, the only real way to find out is to test on > big-endian host... BTW, would that, by any chance, be an open-coded _iowrite64_copy(dst, src, EQ_UNIT/sizeof(u64))