From: Shmulik Ladkani <shmulik@metanetworks.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
Shmulik Ladkani <shmulik.ladkani@gmail.com>
Cc: dsahern@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH iproute2-next] iproute_lwtunnel: allow specifying 'src' for 'encap ip' / 'encap ip6'
Date: Fri, 17 Aug 2018 20:37:29 +0300 [thread overview]
Message-ID: <20180817203729.10c7a830@pixies> (raw)
In-Reply-To: <20180817080022.18e9992d@xeon-e3>
Hi,
On Fri, 17 Aug 2018 08:00:22 -0700
Stephen Hemminger <stephen@networkplumber.org> wrote:
> If you accept an attribute on input you need to parse it and display it the
> same way in the show command.
Note print_encap_ip and print_encap_ip6 already handle LWTUNNEL_IP_SRC
and LWTUNNEL_IP6_SRC (since long ago, 1e5293056 and d95cdcf52).
The only missing part is treatment in parse_encap_ip and
parse_encap_ip6, as suggested by this patch.
Best,
Shmulik
next prev parent reply other threads:[~2018-08-17 20:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-17 7:31 [PATCH iproute2-next] iproute_lwtunnel: allow specifying 'src' for 'encap ip' / 'encap ip6' Shmulik Ladkani
2018-08-17 15:00 ` Stephen Hemminger
2018-08-17 17:37 ` Shmulik Ladkani [this message]
2018-08-17 20:20 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180817203729.10c7a830@pixies \
--to=shmulik@metanetworks.com \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shmulik.ladkani@gmail.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).